New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page/post preview doesn't work after converting legacy post to blocks with Gutenberg #3654

Closed
ElectricFeet opened this Issue Nov 25, 2017 · 5 comments

Comments

Projects
None yet
6 participants
@ElectricFeet
Copy link
Contributor

ElectricFeet commented Nov 25, 2017

Issue Overview

When editing the WP standard "Sample Page" on a brand new site with Gutenberg, the Preview (eye) button opens a new tab displaying the page. After converting the first paragraph to blocks, the preview page hangs.

Steps to Reproduce (for bugs)

  1. From a brand new site, with Gutenberg installed as the only active plugin, edit the page "Sample Page".
  2. Click the Preview (eye) button. A new tab opens with the page preview. All fine so far.
  3. Click the (vertical ellipsis: "Open settings menu") to the right of the first paragraph and choose "Convert to blocks".
  4. Click the Preview (eye) button and a new tab opens with a page saying:

    Please wait…

    Generating preview.

The preview doesn't generate.

Happens on:

  • Mac OS 10.13.1, using BOTH Firefox Quantum 57 and Mac OS Safari 11.0.1.
  • Brand new WP install.
  • No active plugins, apart from Gutenberg.
  • On the client, there are a few pretty standard web extensions installed in Firefox (1Password, uBlock Origin, Privacy Badger etc.) and only two extensions (1Password and uBlock Origin) installed in Safari. But the page preview works fine before converting to Gutenberg blocks, so I don't think the browser extensions are implicated in any way.
  • On the server side, the only thing that's odd is that it's a test environment on an https site using a wildcard certificate, which gives browser errors the first time you access the site. But again, page preview works fine before converting to Gutenberg blocks, so I don't think the server environment is implicated in any way.
  • WordPress 4.9
  • Tested the above with TwentySeventeen and Customizr Pro, with the same results.

Expected Behavior

Should show the page preview.

Current Behavior

It hangs and doesn't show the page preview.

Possible Solution

Screenshots / Video

screen shot 2017-11-25 at 18 58 41

Related Issues and/or PRs

Can't see any.

Todos

  • Tests
  • Documentation

Not clear what this section means in the template...

@ElectricFeet

This comment has been minimized.

Copy link
Contributor

ElectricFeet commented Nov 25, 2017

I should add that once you update the page with the Update button, it previews fine. But of course, the whole point of previewing is to see what it looks like before publishing the changes.

@ElectricFeet ElectricFeet changed the title Page preview doesn't work after converting to blocks with Gutenberg Page preview doesn't work after converting legacy post to blocks with Gutenberg Nov 25, 2017

@ElectricFeet

This comment has been minimized.

Copy link
Contributor

ElectricFeet commented Nov 25, 2017

Added "legacy post" to title, because this doesn't appear with a new Gutenberg-created post, but does happen with the standard "sample post" in a new WP installation.

@ElectricFeet ElectricFeet changed the title Page preview doesn't work after converting legacy post to blocks with Gutenberg Page/post preview doesn't work after converting legacy post to blocks with Gutenberg Nov 25, 2017

@ephox-mogran

This comment has been minimized.

Copy link
Contributor

ephox-mogran commented Nov 27, 2017

I can also replicate this. My steps to replicate were:

  1. Create a new post using the classic editor
  2. Add paragraph and quote to the content
  3. Publish
  4. Edit that post using Gutenberg
  5. Convert to blocks
  6. Preview

For me, it was important that the post had been published first otherwise I couldn't replicate it.

@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018

@jorgefilipecosta jorgefilipecosta self-assigned this Mar 22, 2018

@jeffpaul

This comment has been minimized.

Copy link
Member

jeffpaul commented Mar 22, 2018

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jorgefilipecosta

This comment has been minimized.

Copy link
Member

jorgefilipecosta commented May 24, 2018

Hi @ElectricFeet thank you for reporting this issue.
I retested & did some debugging on this issue, and the cause is that the preview is not working correctly on published posts.
Given that we already have an issue with the cause #4099 I will close this one, so we keep the discussion on the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment