Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview of WP 5.9 pending issues and blockers #36556

Closed
41 of 45 tasks
noisysocks opened this issue Nov 17, 2021 · 16 comments
Closed
41 of 45 tasks

Overview of WP 5.9 pending issues and blockers #36556

noisysocks opened this issue Nov 17, 2021 · 16 comments

Comments

@noisysocks
Copy link
Member

@noisysocks noisysocks commented Nov 17, 2021

馃憢 This list has served its purpose. Head over to the WordPress 5.9 Must-Haves project board to see block editor tasks for WP 5.9.


Last updated: 14 December 2021

馃敽 Blocker for 5.9 Beta (must be fixed before Beta1)
鈿狅笍 Blocker for 5.9 Release (can be fixed after Beta1, must be fixed before RC preferably by Beta 4 to ensure included in a beta release)
馃И Needs testing and feedback

The issues within each section are ordered by priority; contributors are welcome to pick issues from top to bottom in their area of expertise/interest.

Site editing experience

General interface

Navigation block

Global styles & Design tools

Theme blocks

Non-blockers

Site editing experience

General interface

Navigation block

Global styles & Design tools

Block themes

Theme blocks

@noisysocks noisysocks added this to 馃摜 To do in WordPress 5.9 Must-Haves via automation Nov 17, 2021
@noisysocks noisysocks moved this from 馃摜 To do to 馃搵 Tracking issues in WordPress 5.9 Must-Haves Nov 17, 2021
@Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented Nov 17, 2021

Site Editor and site editing workflows
Add templates list page for site editor #36379
[FSE] Update "Customize" link from Appearance > Theme page for block themes #30643
Move Theme Editor to Tools when a block theme is active #36354
[Block Themes] Consider an FSE-compatible approach to starter content #35680
Add a timeout for the in-between-inserter for cases where the onmouseout isn't invoked #35536
Make it easier to unselect blocks #36535
Select mode: Broken icons #36530
Make the UI more clear when you are editing a template part #36533

I think there are some large red flags here that some things are not ready for 5.9. Especially re-creating the entire post list for templates / template parts at the last minute. Don't we want to give new flows ample testing in Gutenberg to ensure they are refined and the desired solution before including them in a core release? We once thought the Nav Panel was a desired solution, imagine if we had shipped that to core WP just days after it had been developed. We would be regretting it now.

Overall, it seems like right now we are rushing things in a dangerous way. We targeted 5.9 as the release for these items in core but too many things are just not ready, hence the rushing to change so many things at the last minute. Wouldn't it be better to miss the expected target date than to rush potentially regrettable decisions and brand new flows into core WP at the last minute?

@priethor priethor changed the title Overview of WP 5.9 blockers Overview of WP 5.9 pending issues and blockers Nov 17, 2021
@oandregal
Copy link
Member

@oandregal oandregal commented Nov 19, 2021

Added a couple of bugs I ran into for the color component

#36640
#36641

@briceduclos
Copy link

@briceduclos briceduclos commented Nov 19, 2021

Can this issue be added to the list: The Group block's layout defaults break existing content #36057. (it's inside the WordPress 5.9 Must-Haves project)

@stacimc
Copy link
Contributor

@stacimc stacimc commented Nov 19, 2021

Should Add an option to configure the site icon in general settings be included in this list? (Currently missing a discoverable way to update the site icon for blocks themes).

@noisysocks
Copy link
Member Author

@noisysocks noisysocks commented Nov 23, 2021

Can this issue be added to the list: The Group block's layout defaults break existing content #36057. (it's inside the WordPress 5.9 Must-Haves project)

Let's use the WordPress 5.9 Must-Haves board for bugs. This list serves as a way to direct contributor focus in addition to the project board.

Should Add an option to configure the site icon in general settings be included in this list? (Currently missing a discoverable way to update the site icon for blocks themes).

I've added this, though without a 鈿狅笍 since there is a workaround.

@aristath
Copy link
Member

@aristath aristath commented Nov 25, 2021

FSE: Fall back to Top level PHP theme templates when no FSE templates are available #24834

Already done in #29026 and further refined in #31604

@mtias
Copy link
Contributor

@mtias mtias commented Nov 25, 2021

Thanks for checking @aristath, it was listed to ensure it got a proper look since it's been a while since it was worked on.

@noisysocks
Copy link
Member Author

@noisysocks noisysocks commented Dec 1, 2021

[Site Editor] Templates list screen overview #36597 鈿狅笍

I'm going to check this one off as the majority of the items in #36597 have been completed.

@mtias
Copy link
Contributor

@mtias mtias commented Dec 3, 2021

We can punt #36535, #36533, #36544.

@hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Dec 8, 2021

Following the discussion #37075 (comment), #37075 is no longer considered a blocker for 5.9. Can the 鈿狅笍 be removed from its title and from the blockers list above? @noisysocks @priethor

@priethor
Copy link
Contributor

@priethor priethor commented Dec 8, 2021

#37075 is still considered a top priority, although we agree it should not jeopardize the release timeline. It is being addressed in #36488, and because Beta 2 is already out I think it's important to keep the 鈿狅笍 and highlight it to get contributors to test it as much as possible.

@hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Dec 8, 2021

#37075 is still considered a top priority, although we agree it should not jeopardize the release timeline. It is being addressed in #36488, and because Beta 2 is already out I think it's important to keep the 鈿狅笍 and highlight it to get contributors to test it as much as possible.

While I appreciate it as priority, 鈿狅笍 is a flag that it blocks 5.9 RC. But that's not the case now. It's something to get into the release if possible, but it no longer a blocker to stop 5.9 RC from happening.

@priethor the list is already prioritized, right? Removing the 鈿狅笍 lets everyone including the release squad, community, etc. know that this issue will not block 5.9 RC or its final release.

@priethor
Copy link
Contributor

@priethor priethor commented Dec 9, 2021

The list is prioritized but visual indicators are most useful. Since you are right about the non-blocking nature and the issue is already fixed by #36488 , I've added a different icon instead to denote testing is required. How does that sound?

@hellofromtonya
Copy link
Contributor

@hellofromtonya hellofromtonya commented Dec 9, 2021

I like that 馃И emoji (will borrow it). Thank you @priethor for updating it!

@noisysocks
Copy link
Member Author

@noisysocks noisysocks commented Dec 14, 2021

I hid the non-blockers underneath a <details> since it's not realistic that we'll be looking at them now that we're past beta 3.

All that's remaining is https://core.trac.wordpress.org/ticket/54489 and #37038.

@noisysocks
Copy link
Member Author

@noisysocks noisysocks commented Dec 15, 2021

I'm hearing feedback that it's confusing to have both this issue and the project board. Given most of the items here are checked off, and the two remaining items are also in the project board, I'm going to close this out.

Let's work on closing out as many items as we can in the project board before RC 1.

@noisysocks noisysocks closed this Dec 15, 2021
WordPress 5.9 Must-Haves automation moved this from 馃搵 Tracking issues to 鉁 Done Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants