Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use title in default theme.json to override "Default" label in Site Editor Style Variations #40491

Open
0aveRyan opened this issue Apr 20, 2022 · 0 comments
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Style Variations Related to style variations provided by block themes [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@0aveRyan
Copy link
Contributor

What problem does this address?

Currently, only Style Variations support the title attribute not the default theme.json.

In the Global Styles panel in the Site Editor Default is hard-coded for naming the default.

What is your proposed solution?

style-variations-custom-name
It would be nice to prescribe a name other than Default.

  • Perhaps the Theme Name (this wouldn't need to be automatic, as it may not be a desired experience in some Themes).
  • Perhaps the default theme.json is Light that pairs nicely with a Style Variation named Dark.
  • Perhaps a name disconnected from Theme Name entirely Whimsical Brand.

By supporting title in the top-level theme.json specification and using it to populate the UI, all those potential outcomes could be addressed.

Happy to open a PR to address.

@0aveRyan 0aveRyan added [Feature] Style Variations Related to style variations provided by block themes [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Developer Experience Ideas about improving block and theme developer experience labels Apr 20, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2023
@carolinan carolinan self-assigned this Jan 11, 2024
@carolinan carolinan removed their assignment Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Experience Ideas about improving block and theme developer experience [Feature] Style Variations Related to style variations provided by block themes [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants