Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Overview: Phase 2 priorities #41549

Closed
24 of 32 tasks
mtias opened this issue Jun 4, 2022 · 22 comments
Closed
24 of 32 tasks

Navigation Overview: Phase 2 priorities #41549

mtias opened this issue Jun 4, 2022 · 22 comments
Labels
[Block] Navigation Affects the Navigation Block [Type] Overview Offers a comprehensive breakdown of a specific area of work to act as a guidepost

Comments

@mtias
Copy link
Member

mtias commented Jun 4, 2022

This issue captures the current priorities for Navigation which we are aiming to include in WordPress 6.2.

Some progress has been made in 6.1, particularly on the theme switching, fallback and new menu facets. Editing menus is now an area that now requires attention.

There's also a longer backlog used to more exhaustively track open issues, bugs, and pending tasks at #38275.

Editing Menus

There are other questions around how to normalize things like "page list" (automated list) and individually curated items, how we handle transitioning from one to the other mechanism, etc. The flows for managing a menu extend beyond the menu itself (as in, it also needs to be taken into account when creating content like pages) and that's important to recognize.

This work for 42257 can be broken down into discrete pieces, some of which can be done in parallel. These in a rough priority order:


At this point we can do some user tests



Nice to haves:


@mtias mtias added [Type] Overview Offers a comprehensive breakdown of a specific area of work to act as a guidepost [Block] Navigation Affects the Navigation Block labels Jun 4, 2022
@mrkdevelopment
Copy link

@mtias Is there a possibility of conditional headers being added to the roadmap?

Scenario: I have 10 header designs. 1 is a default, the other 9 are conditionally loaded on pages where I sent the condition.

I have a couple of simple examples to explain my thinking.

1. Landing Page

I have a landing page and want a different header for this landing page compared to the main site. How would this work with the new navigation / header tools? I want a specific header with custom navigation for these specific pages.

2. Logged in User

I want a conditional header for a logged in user that displays a specific header only when a user is logged in. Is this something that is possible? (I'm not talking about a login or logout block, but the whole header being changed)

3. Custom Header for Blog categories

I want to have a different header on different blog categories. I have 9 categories and can potentially design multiple headers to allocate conditionally.

Are these kinds of features within core or are we looking at these being the realm of third party plugins?

I read over the other tickets but these seemed to be limited to just login / logout and conditional navigation. Not the whole header section or other sections having multiple variations and conditionally being added to pages.

I'm not sure if this is the right place to comment so feel free to move this where it should be.

@mtias
Copy link
Member Author

mtias commented Jul 26, 2022

@mrkdevelopment sorry I missed the questions!

  1. Unless I'm missing something, you'd just use a different header template for your landing page with whatever navigation items you need.
  2. Not possible from the editor UI alone. Can you share how the menus would differ and what would they have in common (if anything) to clarify the need further? Would be good to open a new issue with this request specifically if you don't mind.
  3. This should also be possible with category templates, which can be as specific or broad as you need them to be.

@scruffian scruffian changed the title Navigation Block Overview Navigation Block Overview: Phase 2 priorities Nov 1, 2022
@scruffian
Copy link
Contributor

I updated this issue with the latest priorities for phase 2.

@scruffian scruffian changed the title Navigation Block Overview: Phase 2 priorities Navigation Overview: Phase 2 priorities Nov 1, 2022
@getdave
Copy link
Contributor

getdave commented Nov 17, 2022

Update 17th November 2022

I posted an update on the Tracking Issue to alert folks that progress for 6.2 will be tracked on this Issue. Read that update for details on progress.

Future updates on 6.2 progress will appear here.

@scruffian
Copy link
Contributor

Update 1st December 2022

There has been good progress on the items in the issue description. We now have the basics of the Navigation List View working. It is possible to view, edit and remove navigation items from the inspector controls. Drag and drop also works. The main areas of concern are:

  1. When editing an item, can we show the settings tab?
  2. Can we animate the opening of the block settings to make it clear that this is conceptually a "drill-down" operation

These will be the next areas to focus on. Work is happening on this project board: https://github.com/orgs/WordPress/projects/60/views/1, which should give more detail on progress.

This video shows the current state of the project:
https://user-images.githubusercontent.com/275961/205058431-36250e48-bff3-42a7-a673-997a47d841d5.mov

The issue description will be updated to reflect the current outstanding issues.

@scruffian
Copy link
Contributor

scruffian commented Dec 12, 2022

Update 12th December

This experiment is progressing well, we are now at a point where it can be tested by users, by enabling these two checkboxes:

Screenshot 2022-12-12 at 17 26 11

The main features of the list view are working:

  • The navigation list view is now in its own tab in the block inspector controls.
  • Items in the navigation list view can be edited by drilling down into the inspector controls.
  • Submenu items can be added in the navigation list view
  • Items can be reordered in the navigation list view using drag and drop
  • Page list blocks can be filtered by their parents
  • The navigation list view can be opened from the block toolbar

Screenshot 2022-12-12 at 17 31 55

Many of these features have been enabled by the offcanvas editor experiment. We're looking for feedback about whether this feature is valuable for users and therefore should be made a part of the default experience for the block.

@getdave
Copy link
Contributor

getdave commented Jan 9, 2023

Update 9th Jan 2023

Contributors are now largely back following the Christmas and New Year period.

With the feature freeze for WP 6.2 drawing ever nearer (early February 2023) we are looking to decide whether or not to merge the Offcanvas editor experiment into Gutenberg Core.

Based on the positive feedback received on the recent call for testing it's looking like we will be aiming for including the feature in WP 6.2. However this is based on many factors including whether we can achieve the work necessary to make the feature stable by the feature freeze.

The project board has been reorganised to reflect the priorities for stablising the feature. Project contributors will be focusing on this effort.

A reminder here are the calls for testing:

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

Update 10th Jan 2023

I've created a list of current known accessible issues with the feature. These are being prioritised alongside other elements of fidelity.

@getdave
Copy link
Contributor

getdave commented Jan 25, 2023

Update 25th Jan 2023

Work continues to be heavily focused on the Nav block list view experience:

@getdave
Copy link
Contributor

getdave commented Feb 8, 2023

Update 8th Feb 2023

Contributors continue to focus on resolving bugs for 6.2, including a11y related issues.

Other work is restarting in the background but is not yet up to speed.

@Marc-pi
Copy link

Marc-pi commented Feb 24, 2023

I've just tested "add the search block within the nav", and the XP is not nice !!!
see #48410

@getdave
Copy link
Contributor

getdave commented Mar 8, 2023

Update 8th March 2023

Contributors have been focused on last minute fixes to the Browse Mode Navigation sidebar as well as the Nav block list view editing mode. This is for WP 6.2.

Looking ahead beyond 6.2 contributors have been focused on:

@fabiankaegy
Copy link
Member

Hi all 👋

I think #39644 should be tracked here

@getdave
Copy link
Contributor

getdave commented Mar 15, 2023

Hi all 👋

I think #39644 should be tracked here

It's tracked in #31452 I believe. Also the Tracking Issue is here.

@getdave
Copy link
Contributor

getdave commented Mar 15, 2023

Update 15th March

@Marc-pi
Copy link

Marc-pi commented Mar 15, 2023

Ahead of Browser mode that needs to be designed more globaly (incl. with the upcoming new admin menu in mind / as target)
i'm facing DAILY on projects those limitations during the editing flow, that should be IMHO on top priority if we think about end user and want to make competitive this component :

Some can be managed with custom css, but end users can be surprised not being able to manage this directly within the Editor.

Just to update the task list accordingly with this humble feedback ;-)
Let me know if more details are needed.

@getdave
Copy link
Contributor

getdave commented Mar 15, 2023

@Marc-pi Thank you for the feedback. Let's loop in @WordPress/gutenberg-design on these issues as well so that we can consider them holistically.

Know that we are listening, but as always we will have to balance these against other known issues, bugs, and necessary technical upgrades to the block itself.

Thanks again for taking the time to list these out for contributors. It's very useful and much appreciated.

@jasmussen
Copy link
Contributor

add search block within nav > wrong display

I agree. This seems to have regressed from #31127, I don't have the context for why that is. We also need an icon-only display (#31128).

manage burger icon size + upload custom icon, style it directly from block settings

Also agree, with the immediate solution having already been explored, allowing the upload of icons. SVG turned out to be an obstacle because for security reasons you're not allowed to upload them. While this is something I think we should revisit, in the mean time I recall (but cannot now find) a PR that allowed uploading png files.

Agree with the remaining issues too — I'd love to both allow more customizability of all the pieces, and allowing more blocks inside. I'm excited about #43852 that would allow full customization of the contents inside the overlay menu, and I could see dropdown customizability starting out in theme.json and then a UI being surfaced later on. This might be worth opening a separate issue for, if one doesn't exist already.

@getdave
Copy link
Contributor

getdave commented Mar 17, 2023

Discussion on new priorities for 6.3

With 6.2 nearly released, we should start to look at priorities for 6.3. As I see it the items listed below are the key problems. Note these are high level items and many of them contain specific sub issues.

I would like to discuss this with other contributors:

Theming and Customisation

Creation and management


See also the list of items in the Tracking Issue.

@getdave
Copy link
Contributor

getdave commented Mar 29, 2023

Update 29th March

@getdave
Copy link
Contributor

getdave commented Apr 21, 2023

Update 21st April 2023

Contributors have been working hard at improving the fallback mechanics for the block. This important foundation work has now merged which - due to the number of tests added - puts us in a much better position to move forward with other critical pieces of work.

Contributors are also going to try and agreed a set of key tasks to address for the 6.3 cycle. It's going to be tough as there are a number of competing priorities.

@getdave
Copy link
Contributor

getdave commented Apr 28, 2023

Update: I created a new overview Issue for 6.3 #50165


The tasks on this Issue are almost entirely complete. We should open a new Issue for 6.3 and beyond. The Tracking Issue is the source of truth.

@getdave getdave closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Overview Offers a comprehensive breakdown of a specific area of work to act as a guidepost
Projects
Status: Done
Development

No branches or pull requests

7 participants