Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: sub-menu styles should apply to the sub link only #45878

Open
madhusudhand opened this issue Nov 18, 2022 · 0 comments
Open

Navigation: sub-menu styles should apply to the sub link only #45878

madhusudhand opened this issue Nov 18, 2022 · 0 comments
Labels
[Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.

Comments

@madhusudhand
Copy link
Contributor

What problem does this address?

In the current behaviour, a sub-menu is a container with main navigation link + all the sub menu links.
But, the sub menu should only the container of all sub-links, so that the styles applied to the sub-menu doesn't effect the main navigation link.

What is your proposed solution?

Current expectation
image image

Everything from L1 should always behave as a link.
One of the link might have sub links under it and the container holding all those links should be the sub menu.
Any styling applied to submenu, should get applied to the containing links and container, but not the main nav link itself.

I would like to imagine a scenario where my website has only flat menu first, and then I decide to include nested levels.
In this case I wouldn't expect my main links to get effected by any theme styles, because it is a data change.

However when theme has styles defined for nav-link, that one link having sub-links looks different and it forces me to define styles for submenu to match other navigation links.

Related discussions:

#42963 (comment)

@madhusudhand madhusudhand changed the title Navigation: Sub-menu styles should apply to containing links, not the main menu link itself Navigation: sub-menu styles should apply to the sub link only Nov 18, 2022
@bph bph added [Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Nov 19, 2022
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. [Feature] Navigation Menus Any issue relating to Navigation Menus labels Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Submenu Affects the Submenu Block - for submenus in navigation [Feature] Navigation Menus Any issue relating to Navigation Menus [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants