Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilise LinkUI component in Navigation Submenu #46207

Closed
getdave opened this issue Nov 30, 2022 · 0 comments · Fixed by #46370
Closed

Utilise LinkUI component in Navigation Submenu #46207

getdave opened this issue Nov 30, 2022 · 0 comments · Fixed by #46370
Assignees
@getdave
Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Code Quality Issues or PRs that relate to code quality

Comments

@getdave
Copy link
Contributor

getdave commented Nov 30, 2022

The Nav Submenu block implements a lot of the same functionality as the Nav Link block.

Specifically I've noticed that the handling of creation of links is nearly identical.

gutenberg/packages/block-library/src/navigation-submenu/edit.js

Line 665 in 60c33c4

<LinkControl

In # we extracted the implementation of the Link UI to a <LinkUI> component within the Navigation Link block directly. Let's utilise this inside the Submenu block as well.

As both block's are within the block-library package it should be easy enough to achieve.
@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Block] Submenu Affects the Submenu Block - for submenus in navigation labels Nov 30, 2022
@getdave getdave self-assigned this Nov 30, 2022
@scruffian scruffian mentioned this issue Dec 1, 2022
Closed
32 tasks
@getdave getdave mentioned this issue Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getdave getdave

Labels
[Block] Submenu Affects the Submenu Block - for submenus in navigation [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Shared standard Link UI component between Nav Link and Submenu blocks WordPress/gutenberg
1 participant
@getdave