Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles: Changing the Layout, Padding, and Block Spacing values causes error #49666

Closed
annezazu opened this issue Apr 7, 2023 · 3 comments
Closed
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Apr 7, 2023

Description

This was found as part of the FSE Outreach Program's Build a Block Theme Exploration:

I’m just getting started, but I’m getting errors when I try to change the Content Widths under Global Styles > Layout.
I also can’t change the Padding or Block Spacing. I can add Layout Settings on individual Group Blocks inside the Template and Template Parts (index.html, only right now, and header.html and footer.html.

Step-by-step reproduction instructions

  1. Open Site Editor using WP 6.2 and GB 15.5.0
  2. Edit any template
  3. Open Styles
  4. Head to Layout
  5. Try to change the content width values
  6. See error

Screenshots, screen recording, code snippet

TypeError: Cannot convert undefined or null to object
at Function.entries ()
at er (https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19441)
at https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19481
at Array.map ()
at er (https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19452)
at https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19481
at Array.map ()
at er (https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19452)
at https://fse-block-theme-exploration.instawp.xyz/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=65c2a14c9bcef52f178e:7:19481
at Array.map ()

error.with.layout.mov

Environment info

  • WP 6.2
  • GB 15.5
  • TT3
  • Chrome

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2023
@paaljoachim
Copy link
Contributor

I believe that @tellthemachines and @andrewserong have been working on layout things.

@tellthemachines
Copy link
Contributor

This has been fixed in #49465.

@andrewserong
Copy link
Contributor

It turns out that the fix (#49465) didn't make it into Gutenberg 15.5.0, so I've cherry-picked it into the release/15.5 branch in eab4da1, and pushed a minor Gutenberg release in 15.5.1.

I'll close out this issue now, but feel free to reopen if the issue crops up again in GB >= 15.5.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants