New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the blocks aria-label #5505

Closed
afercia opened this Issue Mar 8, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@afercia
Contributor

afercia commented Mar 8, 2018

Previously, the blocks container used to be focusable with a tabindex="0" and it was labeled with an aria-label attribute to give each block a name. See 1a17201 and related #1618

This was the related markup:

screen shot 2017-06-30 at 17 55 40

This was a nice feature. When navigating through the blocks using assistive technologies, and landing on a block, each block announced its type, for example:
Block: Paragraph
Block: Image
etc.

After recent changes, this aria-label is now on a non-focusable div, see

This is not correct and should be fixed. The aria-label should be set on a container that actually receives focus. It also needs an explicit role attribute, e.g. role="group" if there are no other roles that suit better.

Regardless, it's not clear to me where the focus currently lands and if there are other pending changes planned for the blocks interaction.

Worth also considering the pending experiment about "navigation mode / edit mode":
#3195
#2031

The final goal should always be:

  • allow keyboard and assistive technologies users to easily navigate through blocks
  • correctly label each block
@IreneStr

This comment has been minimized.

Member

IreneStr commented Jun 14, 2018

I've opened a PR to fix the aria-label: #7305
The role-part of this issue is still open and will need some investigation about what the most suitable role.

@IreneStr IreneStr removed their assignment Jun 14, 2018

@jorgefilipecosta

This comment has been minimized.

Member

jorgefilipecosta commented Jun 18, 2018

Hi @afercia, the PR #7305 should have fixed the issue. If you feel any other improvement related to this issue is required to feel free to reopen the issue.
Thank you @afercia and @IreneStr for fixing this problem.

@afercia

This comment has been minimized.

Contributor

afercia commented Jun 18, 2018

Hi @jorgefilipecosta thanks and thanks @IreneStr 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment