Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing cmd/ctrl as a way to navigate into block toolbars #552

Closed
ellatrix opened this issue Apr 28, 2017 · 3 comments · Fixed by #2960
Closed

Pressing cmd/ctrl as a way to navigate into block toolbars #552

ellatrix opened this issue Apr 28, 2017 · 3 comments · Fixed by #2960
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later

Comments

@ellatrix
Copy link
Member

This would be a bit of an experiment for accessibility. @afercia and I talked about tis a few weeks back. At the moment, in the current editor, you need to press some magic f# combination to navigate to the toolbars.

Behaviour:

  • Press command on Mac or ctrl elsewhere.
  • If another key is pressed during, abort.
  • If the key is released without any other key pressed (so it was pressed on its own), show the toolbar and move the focus to the first item.
  • From there on you can use tabbing or arrow keys to move focus between the buttons.
  • If and only if the esc key is pressed, hide the toolbar and refocus the editor at the last position.
  • Clicking works as normal of course.
@ellatrix ellatrix added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later labels Apr 28, 2017
@ellatrix
Copy link
Member Author

@afercia
Copy link
Contributor

afercia commented Apr 29, 2017

some magic f# combination

Ah, I was wondering how to do that :) Big plus from me for the Cmd/Ctrl idea.

@afercia
Copy link
Contributor

afercia commented May 3, 2017

The ARIA authoring practices suggest, as an example, some shortcuts. Most importantly, they describe the expected interaction and some options:

Expected keyboard interaction with a rich text editor
(outdated, read all for the suggested interaction)
https://www.w3.org/TR/2013/WD-wai-aria-practices-20130307/#richtext

In the latest version, there's just a quick mention here (see the note)

https://www.w3.org/TR/wai-aria-practices-1.1/#keyboard-interaction-11
... For example, a rich text editor may have a menubar that receives focus when
a shortcut key, e.g., alt + F10, is pressed while editing.

However, I've never got the reasoning behind that. Alt + F10 doesn't seem the most discoverable and easy to remember shortcut. I'd vote for keeping Alt + F10 for users that are used to that and introduce cmd/ctrl as a new, easier one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants