Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Block doesn't apply the 'post_gallery' filter, causing incompatibility with WP Gallery Custom Links #5972

Closed
mrleemon opened this issue Apr 4, 2018 · 3 comments

Comments

@mrleemon
Copy link
Contributor

commented Apr 4, 2018

Issue Overview

The WP Gallery Custom Links plugin adds a “Gallery Link URL” field when editing gallery images so users are able to create galleries which link to external resources.

https://es.wordpress.org/plugins/wp-gallery-custom-links/

The plugin continues to work on the backend with Gutenberg active, but links are ignored on the frontend.

Steps to Reproduce (for bugs)

  1. Install the WP Gallery Custom Links plugin and activate it
  2. Add a Gallery block to a post and specify custom URLs in some images
  3. Save the post
  4. View the post

Firefox and Chrome

Expected Behavior

The custom links added to gallery images should appear on the frontend

Current Behavior

The custom links added to the gallery images are not appearing on the frontend, gallery images are not clickable

Possible Solution

Screenshots / Video

Related Issues and/or PRs

Todos

@danielbachhuber danielbachhuber added this to the Merge Proposal: Back Compat milestone May 18, 2018

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented May 18, 2018

Related #1451

We need to decide whether Gutenberg needs to support the post_gallery filter, or whether we should expect Gutenberg support for these plugins to be a graceful enhancement.

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented May 21, 2018

I've documented this incompatibility in the migration guide.

@danielbachhuber danielbachhuber changed the title WP Gallery Custom Links plugin is not compatible Gallery Block doesn't apply the 'post_gallery' filter, causing incompatibility with WP Gallery Custom Links May 21, 2018

@danielbachhuber danielbachhuber referenced this issue Jul 18, 2018

Closed

Gallery: Support for ID-less shortcode #3852

0 of 5 tasks complete

@mtias mtias removed this from the Merge: Back Compat milestone Oct 3, 2018

@mtias mtias added this to the WordPress 5.0 milestone Oct 3, 2018

@antpb

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Going to close as discussed in the recent core-media meeting in favor of keeping things focused on #1451

Support for the post_gallery filter will be solved with a fallback to the gallery shortcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.