Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Review the usage of aria-label on the blocks contenteditable #5981
Currently, the various blocks
Though the intent is to give users some instructions or hint about what to type, this is a not proper use of aria-label, as it is supposed to override the element content. I doubt there's any expected behavior about what
Regardless, we shouldn't use
For clarity: when using
so the aria-label makes perfectly sense. Its value should be improved though.
this is not exposed like a text field or textarea. See also #5983
Removing the Needs Testing label as there's not so much to test. The visible placeholder text is used also as value for the aria-label attribute, also when the contenteditable area has content. This is far from ideal and needs to be changed for assistive technologies users. Will expand later with some proposals.