New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the usage of RichText multiline / aria-multiline #6005

Closed
afercia opened this Issue Apr 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@afercia
Contributor

afercia commented Apr 5, 2018

In ARIA terms, role="textbox" and aria-multiline="true" should be used to give elements the semantics of an input field and textarea.

  • role="textbox" + aria-multiline="false" (or omitted) -> input field
  • role="textbox" + aria-multiline="true" -> textarea

In Gutenberg, the aria-multiline attribute is used inconsistently. Paragraphs, for example, are not multiline. However, we'd want them to be announced as textareas, not as input fields.

This is how VoiceOver announces a paragraph right now: "text field":

screen shot 2018-04-05 at 12 51 11

Setting aria-multiline to true makes VoiceOver announce it as a textarea:

screen shot 2018-04-05 at 12 52 24

I'm not sure if the multiline prop on RichText has other purposes, but we should use role="textbox" + aria-multiline="true" on all the blocks RichText we want to be announced as tetareas.

@afercia

This comment has been minimized.

Contributor

afercia commented Jun 18, 2018

Fixed in #7306 /Cc @jorgefilipecosta

@afercia afercia closed this Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment