New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-dismissible notices block the content area. #6340

Closed
jsmoriss opened this Issue Apr 21, 2018 · 12 comments

Comments

Projects
None yet
4 participants
@jsmoriss
Copy link

jsmoriss commented Apr 21, 2018

Gutenberg notices cannot be scrolled, so when creating several non-dismissible notices, the content area is no longer accessible - it's covered in notices that cannot be scrolled up to access the content.

js.

@noisysocks

This comment has been minimized.

Copy link
Member

noisysocks commented Apr 23, 2018

Hey @jsmoriss. Could you provide some reproduction steps for this? e.g. how do I make several non-dismissible notices appear?

I'm going to close this for now but let's definitely re-open it once there's more information.

@noisysocks noisysocks closed this Apr 23, 2018

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 23, 2018

I'm not sure I understand your question - you're asking about how to create Gutenberg notices??? This issue is NOT about creating notices.

Gutenberg puts notices over the content area. If those notices are not dismissible, then the content area is less and less accessible the more non-dismissible notices there are - eventually, the content area is not accessible at all.

@noisysocks

This comment has been minimized.

Copy link
Member

noisysocks commented Apr 23, 2018

@jsmoriss To be clear, are you referring to these notices?

screen shot 2018-04-24 at 09 43 55

I'm unable to re-create a scenario where there are so many notices that the content area is unusably small. Could you please write down some detailed steps to follow and upload a screenshot of the problem?

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 24, 2018

Really? You can't create multiple non-dismissible notices?

I've had to make all my notices dismissible, either for the current view (shown again on save), for the current page load (the Gutenberg default), for a period of time (1 hour, 1 month, etc.), or permanently.

Using non-dismissible notices is not an option because they block the content area.

Example - imagine these are non-dismissible and you get the idea. ;-)

screenshot-2018-4-24 featured image vertical surnia ulula admin wordpress

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 24, 2018

BTW, in case you notice - yes, there's a duplicate error message in there :) - I was working on that when I took the screencap. ;)

js.

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 25, 2018

It floors me that this issue was closed without bothering to understand or re-create the issue.

js.

@noisysocks

This comment has been minimized.

Copy link
Member

noisysocks commented Apr 26, 2018

@jsmoriss: We get a lot of issues and so my preference is to close any that are un-actionable. Without a screenshot or a Steps to Reproduce section in the description, it's really difficult to triage and action an issue. Thanks for being patient and for providing extra information about the issue 🙂

cc. @karmatosed for design input on this.

My feeling is that making notices scrollable is not something that we would support natively, as they're intended to be short messages that convey to the user that an asynchronous task has finished. It's probably better that persistent information such as SSO validation errors are located somewhere permanent e.g. the post sidebar.

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 26, 2018

Non-dismissible notices are a potential issue with the current design of Gutenberg notices - another option would be to remove support for isDismissible and make all notices dismissible.

Note that to access the content area, when there are multiple notices, the user MUST dismiss the notices. In some cases, this means dismissing the error for a period of time, or permanently, which may not be what the user really wants to do - but might be required to access the content area.

On a personal note - The WordPress notification / notice system has always been a problem, and Gutenberg seems to have made it worse.

js.

@karmatosed

This comment has been minimized.

Copy link
Member

karmatosed commented Apr 27, 2018

@jsmoriss this is a foundational issue with they messaging in WordPress and I don't overly agree Gutenberg has made it worse as much as exposed it maybe. That all said, it doesn't get us a solution, so let's turn to that as a focus. I think where possible errors being contextual is a better option, I don't think making an area scrollable does that.

This is a longer term issue but, what we should do I think in this case is turn our attention to core and work to make handling of messages better there, we can then have them work better in Gutenberg. That said again ultimately it's a really poor user experience to have that amount of notices that can't be dismissed. I would encourage you to consider adding by the issue as a better option.

One possible 'now' option could be simply to only show latest 3 messages and have a 'notice' with a 'click to show more messages'. I don't like this as a solution though as it doesn't solve the ground problem, WordPress and plugins shouldn't be filling your page full of messages like this.

I do think it should be something that should be fixed in longer term. To that point core has an issue for notifications, this could enable better options eventually. Having this many notices that can't be removed or actioned by a user isn't the best option, I would still encourage you to explore that and look at ways to reduce messaging in the number there are - that's a longer term goal.

@jsmoriss

This comment has been minimized.

Copy link

jsmoriss commented Apr 27, 2018

Gutenberg has hidden the native WordPress notices, and from what I understand, Gutenberg developers assume / expect to show only 1 or maybe 2 single sentence notices. In some cases, more complete warning and error messages may be required for missing / incorrect content - as shown in this example. Obviously this example should not be taken as somekind of high / low-water mark - 3rd party developers will use the Gutenberg notices in different ways - how and why they use them is up to those developer.

I am reporting that blocking the content area with notices is a serious design issue. Dismissible notices force the user to dismiss the notices to gain access to the content area. Some notices may be dismissed temporarily, for a longer period of time, or permanently. Forcing users to permanently dismiss a notice (for example) to gain access to the content area is a serious problem. Non-dismissible notices create an even bigger problem since they cannot be dismissed, so the content area may be inaccessible.

If you would like to deal with this issue as a "Question" (as you've labeled this issue), then obviously that's up to you, but I don't agree. Fundamentally, I think the display of notifications in Gutenberg is flawed. Since Gutenberg hides WordPress notifications, developers will have to use Gutenberg notices and live with the awful UI experience for the user, as you've stated.

js.

@karmatosed

This comment has been minimized.

Copy link
Member

karmatosed commented Apr 27, 2018

Let me add 'needs decision' as a that probably is a solid option for getting opinions and insights, that's what I meant by question.

@jsmoriss jsmoriss changed the title Cannot scroll non-dismissible notices Non-dismissible notices block the content area. May 7, 2018

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 26, 2018

closing as duplicate of #12243 which is a bit more active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment