Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert link: unify link interfaces #6392

Closed
karmatosed opened this issue Apr 24, 2018 · 11 comments

Comments

@karmatosed
Copy link
Member

@karmatosed karmatosed commented Apr 24, 2018

Right now we have a little variation on styling for links, most have been update to the current one but lets fix those that haven't.

Here is the latest interface:

link-paragraph

This however on images right now isn't updated here:

link-image

You can see it even more, when you have both link interfaces open:

link-images-both

For buttons you get the following:

link-button

I would suggest we should unify the links and have everything use the same like we do in these examples:

link-coverimage

link-quote

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Jul 19, 2018

@karmatosed what's the status of this one? Maybe we need specific issues for any that are wrong.

@designsimply

This comment has been minimized.

Copy link
Member

@designsimply designsimply commented Sep 7, 2018

@karmatosed would you like me to split this issue out into more specific ones or would it be better to wait for a unified design to be posted here first?

Regarding design, would it be possible to note the post type (e.g. Page, CPT name, or the date for posts) on the right for suggested links or should that be filed as a separate issue? Note: asking because it was requested in #9660.

screen shot 2017-07-29 at 17 39 06
Example screenshot from #2084 showing how post types are listed in link suggestions in the classic editor.

@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Sep 8, 2018

@designsimply and @mtias, yes let's split this out into issues for each one. Let's first focus though on unifying over adding new features right now. We totally can later but the bigger issue is if each one doesn't do the same.

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Oct 12, 2018

@karmatosed what is the status of this?

@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Oct 15, 2018

We need to fix for button only:

button

@afercia

This comment has been minimized.

Copy link
Contributor

@afercia afercia commented Oct 20, 2018

@designsimply when you have a chance 🙂 has the post type / date thing been split in a separate issue? Couldn't find one. Thanks! /Cc @azaozz

@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Nov 1, 2018

To illustrate what this needs. Right now we have this:

1

Ideally we would have the link design to be the same as the other instances:

2

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Nov 1, 2018

Ideally we would have the link design to be the same as the other instances:

The button shows the url input on selection of the block, should it still use a dropdown menu in that case?

@karmatosed

This comment has been minimized.

Copy link
Member Author

@karmatosed karmatosed commented Nov 2, 2018

The button shows the url input on selection of the block, should it still use a dropdown menu in that case?

My feelings are yes because that's our interface for linking. It isn't perfect but right now feels a good step. For example even without text, you get the following for cover image:

2018-11-02 at 09 42

@mtias

This comment has been minimized.

Copy link
Contributor

@mtias mtias commented Nov 12, 2018

The biggest outlier seems to be the Button block. Punting this from 5.0 as improvements there can be done later.

@designsimply

This comment has been minimized.

Copy link
Member

@designsimply designsimply commented Feb 1, 2019

I am closing this issue and deferring to #8000 as the last issue remaining for the request to unify the link interfaces for the paragraph, button, image caption, cover image, and quote blocks. See audit details below.

/hat tip @nfmohit-wpmudev and @kadencethemes for proposing solutions to #8000 in #10128 and #12738 respectively.

I audited link inserters for the following blocks:

  1. Paragraph
  2. Button
  3. Image (done in sidebar not popover)
  4. Image caption
  5. Cover image
  6. Quote

And found the following:

  1. Image block currently does not have a Urlpopover link inserter, image links are set in the sidebar and this looks to be by design (screenshot).
  2. Button block link inserter does not match the rest (screenshot).

screen shot 2019-02-01 at 11 37 27 am

I also moved the request to include different post types and the dates of posts to the suggested links to #13641. cc @afercia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Phase 2
  
Done
6 participants
You can’t perform that action at this time.