New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enter Button Block URL using keyboard #6841

Closed
maddisondesigns opened this Issue May 19, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@maddisondesigns

maddisondesigns commented May 19, 2018

Describe the bug
I had a feeling that this issue issue may have been raised before but I can't find it.

When you enter a url for a button, you can't hit the Return key to apply your changes.

On top of that, if you type a url without the https:// it displays a random result from your site and when you hit Return, it actually selects that result instead of using the url you typed

To Reproduce
Steps to reproduce the behavior:

  1. Add Button Block
  2. Type google.com into the URL field
  3. Hit return key to apply changes

Expected behavior
I should be able to simply enter a URL and hit Enter/Return to apply the changes

Screenshots
gutenberg_buttonblock

macOS Sierra 10.12.1 (16B2659)
Firefox Quantum 60.0 (64-bit)
WordPress 4.9.6
Gutenberg 2.9.0

@maddisondesigns maddisondesigns changed the title from Can't enter Button URL using keyboard to Can't enter Button Block URL using keyboard May 19, 2018

@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 22, 2018

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented May 22, 2018

On top of that, if you type a url without the https:// it displays a random result from your site and when you hit Return, it actually selects that result instead of using the url you typed

This is a bug. We should make sure the first search result isn't automatically selected.

@brandonpayton

This comment has been minimized.

Member

brandonpayton commented Sep 15, 2018

Tested and confirmed this is still a bug.

@afercia

This comment has been minimized.

Contributor

afercia commented Sep 17, 2018

Maybe I'm missing something. I've just tested it:

  • typed wordpress.org
  • got some search results but I've ignored them and just pressed Enter
  • I got the entered value in the markup: <a class="wp-block-button__link" href="wordpress.org"></a>

However, there's no validation or feedback at all: search suggestions stay open, nothing informs me a link has been added, the resulting href attribute is invalid. See also #1838

@brandonpayton

This comment has been minimized.

Member

brandonpayton commented Sep 17, 2018

@afercia, thanks for catching that. I'm seeing the same. The link is saved but with no validation or indication it occurred.

It would be good to get design feedback on how we should:

  • Communicate validation errors.
  • Convey that the URL has been saved.

I'm leaving this open since this speaks to URL editing for the Button block. Hopefully answers here or in #1838 can be useful for both.

@mtias

This comment has been minimized.

Contributor

mtias commented Oct 27, 2018

Let's consolidate on #1838 for the validation so it can be bumped in priority.

@mtias mtias closed this Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment