Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Link to image needs "open in new tab" option #6891

Closed
burnuser opened this issue May 22, 2018 · 6 comments

Comments

Projects
None yet
7 participants
@burnuser
Copy link

commented May 22, 2018

We have the (needed!) "open in new tab" option for text links. But image linking is missing this option.

For example if using icons of external websites as link source (Facebook, an NGO, Companys, ...) the "open in new tab" option is also needed!

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented May 22, 2018

Related #6392

@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 22, 2018

@mtias mtias added the Media label Jul 19, 2018

@designsimply designsimply removed the Blocks label Jul 27, 2018

@designsimply

This comment has been minimized.

Copy link
Contributor

commented Jul 27, 2018

Tested and confirmed that if I click the edit (pencil) icon for an already-inserted image in the classic editor, I can see an option to "Open link in a new tab," but if I select an image block in Gutenberg then I cannot see the same option in Settings > Block > Link Settings. Adding screenshots for reference:

screen shot 2018-07-27 at fri jul 27 4 16 29 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=14068&action=edit (Classic editor) running WordPress 4.9.7 using Firefox 61.0.1 on macOS 10.13.6.

screen shot 2018-07-27 at fri jul 27 4 22 00 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=14068&action=edit (Gutenberg editor) running WordPress 4.9.7 and Gutenberg 3.3.0 using Firefox 61.0.1 on macOS 10.13.6.

@antpb

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2018

I'm going to work on getting this going. Can we get some design feedback on if we should have the option in both the modal and the editor? I think exposing this option only in the editor is what we need.

@chrisvanpatten

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

@antpb There's already an open PR at #9520 that probably just needs a refresh :)

@antpb

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2018

Awesome, I'll assign this to myself and get a refresh going! Thanks @chrisvanpatten !

@antpb antpb self-assigned this Oct 5, 2018

@antpb

This comment has been minimized.

Copy link
Contributor

commented Oct 24, 2018

Looks like this is solved now that #9520 is merged.

@antpb antpb closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.