Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic block: toolbar buttons have wrong colors when active #6978

Closed
afercia opened this issue May 28, 2018 · 5 comments

Comments

@afercia
Copy link
Contributor

commented May 28, 2018

  • use a Classic block
  • in order to have a button in an "active state", either:
  • add some text, make a selection and press the Bold button
  • or press the "More" button to reveal the second toolbar
  • the active buttons have a white text against a light gray background:

screen shot 2018-05-28 at 14 24 14

Seems some recent minor regression, as I haven't noticed this happening until today.

@afercia

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2018

In Gutenberg 2.6.0 the Classic block active buttons used to have a dark background:

screen shot 2018-05-31 at 11 36 04

@nfmohit-wpmudev

This comment has been minimized.

Copy link
Member

commented May 31, 2018

This issue seems to have been introduced in the latest WP release (4.9.6). I'm assuming this might be due to TinyMCE's update to 4.7.11.

However, this only happens in Gutenberg editor and not the classic editor because of the way the wp-includes/css/editor.css file in being enqueued.

In case of the classic editor, it is enqueued inside the wp-content-wrap element, i.e. after TinyMCE's skin CSS is enqueued (in <head>).

In case of the Gutenberg editor, the wp-includes/css/editor.css is enqueued in <head> prior to TinyMCE's skin CSS, as a result, the TinyMCE's skin CSS is holding more priority, thus causing the issue.

Looking forward to feedback if this should be addressed in WP itself or separate styles should be added in Gutenberg to overcome this?

@nfmohit-wpmudev

This comment has been minimized.

Copy link
Member

commented May 31, 2018

Just sent a PR #7054 in case this needs to be addressed in Gutenberg. I'm open to suggestions if this could be done in a better way. Thank you!

@claudiobrandt

This comment has been minimized.

Copy link

commented Aug 18, 2018

Not sure if this warrants a separate issue, but besides the active buttons having the wrong color scheme in the Classic Block, as pointed by @afercia, the button that's called "More" is actually named "Toolbar Toggle" in the classic editor. If this renaming was intentional, I believe it would make more sense that "More" be re-labeled "Less" when active.
12s

@aduth

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

As I understand it, this is to have been resolved by #9680 (cc @jasmussen).

@claudiobrandt If your issue still persists, can you open a new separate issue?

@aduth aduth closed this Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.