New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secondary settings button missing descriptive text #7203

Closed
anevins12 opened this Issue Jun 7, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@anevins12
Contributor

anevins12 commented Jun 7, 2018

Describe the bug
The secondary settings button has "More" as its aria-label, but this does not describe what it represents and its action.

To Reproduce
Steps to reproduce the behavior:

  1. Edit a page
  2. View the markup of the three dotted settings icon beside the cog icon.

example

Expected behavior

  • The label of the button should describe what it is and what it does.
  • That text should change when the action changes (when it has been expanded).

For example, the label could be changed from "More" to "Show additional settings" and "Hide additional settings" when content has been expanded.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Browser: Chrome
  • Version: Latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment