New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalinks editing has vanished #7467

Closed
karmatosed opened this Issue Jun 22, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@karmatosed
Member

karmatosed commented Jun 22, 2018

Right now on master the permalink editing has gone:

2018-06-22 at 11 26

@tofumatt

This comment has been minimized.

Member

tofumatt commented Jun 22, 2018

After git bisecting things it looks like 1f9d0b4 is the culprit commit. Checking into things now and trying to fix it.

tofumatt added a commit that referenced this issue Jun 22, 2018

@tofumatt tofumatt referenced this issue Jun 22, 2018

Merged

fix: Show permalink editor in editor #7494

4 of 4 tasks complete

tofumatt added a commit that referenced this issue Jun 25, 2018

tofumatt added a commit that referenced this issue Jun 26, 2018

fix: Show permalink editor in editor (#7494)
* fix: Show permalink editor in editor (fix #7467)
* Use getCurrentPost() to get the link
@aduth

This comment has been minimized.

Member

aduth commented Jun 26, 2018

We should consider adding an end-to-end test to verify that permalinks editing works as expected.

@tofumatt

This comment has been minimized.

Member

tofumatt commented Jun 26, 2018

Agreed, filed #7554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment