Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locking a Block and Block Outlines #7469

Open
mtias opened this issue Jun 22, 2018 · 6 comments

Comments

@mtias
Copy link
Contributor

commented Jun 22, 2018

Not sure about this, but as part of reducing the visual weight in nested contexts, I think we should not render most of the UI on locked templates. For example, if we have a wrapper block, with some column blocks inside, and the wrapper is set to be locked, we should avoid rendering individual column outlines, or fade the outline further.

@karmatosed

This comment has been minimized.

Copy link
Member

commented Jun 25, 2018

I would +1 to fading the outline. I also am very aware nesting rapidly becomes quite a concentrated heavy interface.

@kraftner

This comment has been minimized.

Copy link

commented Jun 26, 2018

But what if that wrapper block needs to be selectable because even though it is locked it has some attributes that have Inspector Controls?

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2018

@kraftner I wonder if this is a situation where block breadcrumbs in the sidebar might be useful. See this comment on #6459.

@mtias mtias added the Needs Design label Jul 19, 2018

@karmatosed karmatosed added this to the WordPress 5.0.1 milestone Nov 22, 2018

@mtias mtias modified the milestones: WordPress 5.0.1, Future: 5.1 Nov 30, 2018

@mapk mapk added this to To do in Phase 2 design Jan 23, 2019

@karmatosed karmatosed removed this from To do in Phase 2 design Jan 31, 2019

@karmatosed karmatosed added this to To Do in Phase 2 via automation Jan 31, 2019

@karmatosed karmatosed moved this from To Do to Tighten Up in Phase 2 Feb 19, 2019

@kjellr

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2019

👋 Block outlines have changed a bit since this issue was filed, and will likely change more if #14961 makes it in. In the meantime, I'm having a little trouble understanding the nature of this issue. I think a couple more examples (ideally visual ones, even if they're messy!) would help explain the concept here a little more clearly. Thanks!

@mtias

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@kjellr this is about using blocks to define structure, but preventing its UI (selection state, outlines, toolbar, etc) from showing up. Imagine the current "post content" as a container block that has no interface — it just transparently contains all the blocks.

@chrisvanpatten

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

I would actually say this is even more valuable if #14961 gets merged, because it gives container blocks an even greater visual weight/visibility. The changes in #14961 make a lot of sense if visualising the container itself is important, but in some cases the container itself is more of an implementation detail which should be invisible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
You can’t perform that action at this time.