Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of floated images #8355

Closed
Clorith opened this issue Aug 1, 2018 · 1 comment
Closed

Improve handling of floated images #8355

Clorith opened this issue Aug 1, 2018 · 1 comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@Clorith
Copy link
Member

Clorith commented Aug 1, 2018

Describe the bug
When an image block is floated, it "merges" to whatever block is next to it, you are no longer able to move the image, so if you wanted to float it right, disliked the placement and wanted to move it around, you now have to un-float the image, move it next to a new block, and then float it again. The problem here is you may not want it wrapped with that specific line of text in the block, you may have a 10 line paragraph and the image should come in and float at line 7.

To Reproduce
Steps to reproduce the behavior:

  1. Create a post with a few paragraphs of text
  2. Insert an image block anywhere between the paragraphs
  3. Choose the float this image left or right (doesn't matter which way)
  4. Decide it should be somewhere else and try to move it

Expected behavior
Once the image is floated, it loses it's block boundary, so you can't drag it around by holding and dragging in the gutter. I expect an image that's now technically been converted to a static inline image, to be draggable by clicking and holding on the image, then moving it to where I want it.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome 68
  • Gutenberg 3.4.0
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Aug 1, 2018
@designsimply
Copy link
Member

designsimply commented Aug 1, 2018

Moved to #7500 so we can consolidate. #7500 covers how to handle floated blocks in general.

Thank you for your feedback @Clorith!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants