New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittently, multiple preview tabs are opened in the preview e2e test #8367

Closed
notnownikki opened this Issue Aug 1, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@notnownikki
Member

notnownikki commented Aug 1, 2018

Describe the bug

See: https://github.com/WordPress/gutenberg/pull/8301/files#diff-46acebe2b5c3907767eb03ce378ad48fR106

To Reproduce

  1. Be me. Half joking here, but this is intermittent and of all the environments I've seen this happen in, it's most frequent on my baremetal linux setup.
  2. Remove the part of the code from the above commit that closes and opens the preview tab
  3. Run the test in non-headless mode (makes no difference, but you can see the effect)
  4. Sometimes, the test opens two preview tabs, and should not.

Expected behavior

There should only ever be one preview tab open.

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Aug 13, 2018

Member

Has this been resolved? Thinking by either #8301 and/or #8330

Member

aduth commented Aug 13, 2018

Has this been resolved? Thinking by either #8301 and/or #8330

@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki

notnownikki Aug 13, 2018

Member

Will move this up on my list of things to check!

Member

notnownikki commented Aug 13, 2018

Will move this up on my list of things to check!

@notnownikki

This comment has been minimized.

Show comment
Hide comment
@notnownikki

notnownikki Aug 13, 2018

Member

Looks fine now! I've opened a PR to remove the workaround at #8928

Member

notnownikki commented Aug 13, 2018

Looks fine now! I've opened a PR to remove the workaround at #8928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment