New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese more tag text overflows in the editor. #8750

Open
miminari opened this Issue Aug 9, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@miminari

miminari commented Aug 9, 2018

In Japanese, more tag text is overflows in the editor.
'More' is translated as '続きを読む' in Japanese.
But we can just read '続きを' or '続きを読'.

The size attribute of input tag is not work in Japanese (and the other 2 byte languages, maybe)
properly.
So, could you add width of CSS at /core-blocks/more/edit.js ?

I think it better the CSS width value is value.length + 2 em.

Screenshots
screenshot2018-08-09 12 31 34

Desktop:

  • OS: macOS High Sierra 10.13.4
  • Browser: chrome 68.0.3440.106, safari 11.1

Smartphone:

  • Device: iPhoneX
  • OS: iOS
  • Browser safari
  • Version 11.4.1

Additional context

  • version of Gutenberg: 3.4.0

@pento pento added this to the 3.6 milestone Aug 9, 2018

@pento

This comment has been minimized.

Show comment
Hide comment
@pento

pento Aug 9, 2018

Member

Thank you for the bug report, @miminari! I agree this is not ideal, I'll create a fix for this shortly.

Member

pento commented Aug 9, 2018

Thank you for the bug report, @miminari! I agree this is not ideal, I'll create a fix for this shortly.

@pento pento referenced a pull request that will close this issue Aug 9, 2018

Open

Fix the More Block input width #8751

4 of 4 tasks complete

@youknowriad youknowriad modified the milestones: 3.6, 3.7 Aug 15, 2018

@youknowriad youknowriad modified the milestones: 3.7, 3.8 Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment