New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a "Save as Pending" button to make the pending state more clear for ongoing updates by editors/administrators #8894

Closed
imath opened this Issue Aug 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@imath
Copy link
Contributor

imath commented Aug 12, 2018

Describe the bug
Pending management can be confusing for Editors / Administrators if they want to keep a post/page in review or add a new one to the pending reviews.

To Reproduce
Steps to reproduce the behavior:

  1. As a contributor
  • I can save my post in draft mode ;
  • When I click on the "Publish..." button of the fixed top bar, the confirmation message informs me my post will be pending a review from an editor.
  1. As an Editor
  • If i want to keep the post in Pending, I must click on the "Save Draft" of the fixed top bar, otherwise clicking on the "Publish..." does what it means : it's publishing the post even if the Pending review checkbox is active.
  • if activate the Pending review checkbox for a page i want to submit for review, i must click on the "Save Draft" button to have the page in Pending review.

Expected behavior
As an editor/administrator, if the "Pending Review" checkbox is active the "Save Draft" button should have its text edited to "Save as Pending". Deactivating the "Pending Review" checkbox should then edit the text of the "Save as Pending" button to "Save Draft".

Screenshots
Here are 2 screenshots

classic-editor
In the classic editor the "Save Draft" button has been replaced by a "Save as Pending" button

modern-editor
In the Gutenberg the "Save Draft" button has not been replaced by a "Save as Pending" button

Desktop (please complete the following information):

  • OS: macOS High Sierra
  • Browser: Chrome
  • Version: 68.0.3440.106

Additional context

  • Gutenberg 3.5.0.

@designsimply designsimply changed the title Keeping/Adding posts/pages as Pending is confusing for Editors and Administrators Consider adding a "Save as Pending" button to make the pending state more clear for ongoing updates by editors/administrators Aug 14, 2018

@imath

This comment has been minimized.

Copy link
Contributor

imath commented Aug 15, 2018

Thanks a lot for your edits.

imho it's more a bug than an enhancement. Having the Pending Review checkbox active, if you click on the "Save Draft" button, you are not saving as draft but saving as pending 🤔

imath added a commit to imath/gutenberg that referenced this issue Aug 31, 2018

Use "Save as Pending" when the Pending checkbox is active
This my suggestion to fix WordPress#8894, an issue I posted 2 weeks ago. It simply gets the edited post status and use "Save as Pending" instead as "Save Draft" if this status is pending (meaning the Pending checkbox is active). As soon as this checkbox is unchecked, the button use "Save Draft".

imath added a commit to imath/gutenberg that referenced this issue Oct 9, 2018

Use "Save as Pending" when the Pending checkbox is active
This my suggestion to fix WordPress#8894, an issue I posted 2 weeks ago. It simply gets the edited post status and use "Save as Pending" instead as "Save Draft" if this status is pending (meaning the Pending checkbox is active). As soon as this checkbox is unchecked, the button use "Save Draft".

imath added a commit to imath/gutenberg that referenced this issue Oct 10, 2018

Use "Save as Pending" when the Pending checkbox is active
This my suggestion to fix WordPress#8894, an issue I posted 2 weeks ago. It simply gets the edited post status and use "Save as Pending" instead as "Save Draft" if this status is pending (meaning the Pending checkbox is active). As soon as this checkbox is unchecked, the button use "Save Draft".

youknowriad added a commit that referenced this issue Oct 15, 2018

Use "Save as Pending" when the Pending checkbox is active (#9495)
* Use "Save as Pending" when the Pending checkbox is active

This my suggestion to fix #8894, an issue I posted 2 weeks ago. It simply gets the edited post status and use "Save as Pending" instead as "Save Draft" if this status is pending (meaning the Pending checkbox is active). As soon as this checkbox is unchecked, the button use "Save Draft".

* As a contributor do not show the "Save as pending" secondary button
Once the post has been submitted for review, this button duplicates with the primary button for the contributor role. It is only interesting for higher roles to eventually keep the post as pending.

* Use a "Submit for review..." label for the major action of the post publish toggle

* The "Save draft" button needs to be shown to the contributor until post is submitted for review

* Capitalize the R or Review to be consistent with the publish panel button

* Keep "Publish..." even for Pending status & Revert "Use a "Submit for
review..." label for the major action of the post publish toggle"

This reverts commit 02f09ae.

etoledom added a commit that referenced this issue Oct 15, 2018

Use "Save as Pending" when the Pending checkbox is active (#9495)
* Use "Save as Pending" when the Pending checkbox is active

This my suggestion to fix #8894, an issue I posted 2 weeks ago. It simply gets the edited post status and use "Save as Pending" instead as "Save Draft" if this status is pending (meaning the Pending checkbox is active). As soon as this checkbox is unchecked, the button use "Save Draft".

* As a contributor do not show the "Save as pending" secondary button
Once the post has been submitted for review, this button duplicates with the primary button for the contributor role. It is only interesting for higher roles to eventually keep the post as pending.

* Use a "Submit for review..." label for the major action of the post publish toggle

* The "Save draft" button needs to be shown to the contributor until post is submitted for review

* Capitalize the R or Review to be consistent with the publish panel button

* Keep "Publish..." even for Pending status & Revert "Use a "Submit for
review..." label for the major action of the post publish toggle"

This reverts commit 02f09ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment