New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change colour when choosing blog "list" #9016

Open
Sixtina1990 opened this Issue Aug 15, 2018 · 8 comments

Comments

Projects
None yet
6 participants
@Sixtina1990

Sixtina1990 commented Aug 15, 2018

Describe the bug
When choosing/adding the block "list", I am unable to change the color on the right side.

To Reproduce
Steps to reproduce the behavior:

  1. Go to create a new post
  2. Click on '+.' (top left) and add new block "list"
  3. On the right side there is no option to change colour like when I choose heading or paragraph.

Expected behavior
I would like to see the same menu on the right side to change the colour as if I add a headline or paragraph.

Screenshots
Attached.

Desktop (please complete the following information):

  • OS 10.13.6
  • Safari 11.1.2

Smartphone (please complete the following information):
N/A

Additional context
-I dont know how to see the version of Gutenberg. It is the one available on Wordpress.
bildschirmfoto 2018-08-15 um 14 38 43

@theincogtion

This comment has been minimized.

theincogtion commented Aug 23, 2018

Also discovered this issue. Workaroud is to use html:
grafik

@karmatosed

This comment has been minimized.

Member

karmatosed commented Aug 26, 2018

In this case whilst I understand the want for this let's hold a little and consider design feedback on if we add or not. There is more impact than just adding to this, for example should we expand to other blocks? A list isn't the same as a paragraph and this absolutely could be needed functionality, but let's judge if it is widely wanted and then see what other blocks do - it would be better to roll out to every block we decide needs this.

Thanks for your raising of this though and let's get some opinions now this has the feedback label.

@ZebulanStanphill

This comment has been minimized.

Contributor

ZebulanStanphill commented Aug 26, 2018

I am ever so slightly skeptical of the need for background color options on a List block. That seems like an area that should be covered by a Container block, but then again, considering that setting off a single Paragraph with its own background and text color is handy in some cases, perhaps the same could be done for a List.

The issue I see is that usually lists do not stand alone; there is an introductory paragraph (even if just one line) that precedes it, and if you were to highlight that part of an article, you would want to have a shared background between them. This seems like a case where it makes sense to apply a background color from a Container block, rather than applying the same background color to two blocks, with may not have the desired effect due to margins between the List and Paragraph.

I think the same applies to a lesser extent for the Heading block, though I can see those standing alone more often.

However, I definitely have no objections to adding text color options to the Heading, List, and Verse blocks. I think that if a Container block was implemented with a text color option to set the default text color for its children, the need for text color options on the individual text-related blocks would be reduced, but I can still see some use-cases for wanting a common background color in a section but different text colors for the headings versus the paragraphs and possibly also the lists.

Additionally, I think the Verse block should have both background and text color options like the Paragraph block, since a poem/song/haiku can often stand alone.

Note also that themes should provide default block styles and style variations, so setting custom background/text colors would most commonly happen on sites that made a lot of use of differently colored sections. This is mostly a page building thing, and is not common for blog posts. You don't usually color different sections of your blog post with different background and text colors, but you do that a lot in page building for many websites.

@Sixtina1990

This comment has been minimized.

Sixtina1990 commented Sep 3, 2018

Thank you for the feedback. I would need it because my blog is in 2 languages and therefore Choose two colours, but I understand your point.

I hope more people will need the color function and that in the future it will be an added feature. In the mean time I can try to use the HTML workaround. Could some tell me the steps where exactly I have to click and copy paste what kind of text? Thank you all for your help. Much appreciated.

@ZebulanStanphill

This comment has been minimized.

Contributor

ZebulanStanphill commented Sep 4, 2018

@Sixtina1990 Go to Appearance→Customize→Additional CSS:

image

image

Create classes for each color you would like to apply to a block, using CSS like this:

.class-name-here {
	color: rgb(255, 0, 0);
}
.another-class-name {
	color: rgb(0, 0, 255);
}

image

You can apply classes to a block in the block inspector:

image

Note that currently, you will not be able to see the styling of the class in the editor.

See also the discussion in #7551 and #9534.

@0aveRyan

This comment has been minimized.

Member

0aveRyan commented Sep 6, 2018

Perhaps this isn't a popular opinion, but I think all text-based blocks should come with Color controls by default -- or none at all (so yes, removing from Paragraph).

I'm concerned the Paragraph Block will be deployed in situations there is another designated Block, simply to achieve effect, and sometimes at the cost of semantic value.

  • If content has every Paragraph block color-treated, Headings will starkly stand out, which may not be desired, so they may opt for a Paragraph with bold and large text.
  • If an author wants a color-treated Quote/Pullquote, they may create a Paragraph and italicize text.
  • Users may end up adding lots of discrete CSS classes in Addl CSS Class, which may not be the end of the world, but seems to add unnecessary complexity.

Perhaps not all Blocks need Color Settings surfaced at the top level and could tuck into Advanced?

Benefits of Colors in List Blocks

  • Pro/Con lists with green/red background.
  • Visually separate a list a cue to users that the list is supporting data/sidebar facts, but not necessarily part of the story flow, and can be scanned over.

Benefits of Colors in Heading Blocks

  • Indicate a section is about a brand (in a post about Top 4 Universities for X, use the university colors in the headings)
  • Indicate a Pro section or Con section akin to Lists, but for subsequent paragraph text.

Benefits of Colors in Quote & Pullquote Blocks

  • Aforementioned Pro/Con treatment
  • Indicate political party of speaker (in the U.S., these would be Red & Blue treatments)
  • News websites often put quotes in a brand color (often to add visual intrigue and separation in lieu of media)
@0aveRyan

This comment has been minimized.

Member

0aveRyan commented Sep 6, 2018

To @ZebulanStanphill's point, if Colors were only on Container blocks by default, that might be the least-confusing compromise and not require surfacing colors on every block.

@Sixtina1990

This comment has been minimized.

Sixtina1990 commented Sep 11, 2018

@ZebulanStanphill Thank you so much :) I just did it and works all well. I am happy! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment