New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the reusable blocks "Export as JSON" link #10003

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
3 participants
@afercia
Contributor

afercia commented Sep 18, 2018

Description

This PR improves the Export as JSON link by referencing the block title in the aria-label attribute (as it's standard in core) and changing the link to a button. For more details, please see #10002

How has this been tested?

  • npm test gives a failing (unrelated?) test
  • I've tested it with the fix from #10000 with Firefox and it works correctly, still have to test it with IE 11

/Cc @youknowriad

Fixes #10002

@afercia afercia requested a review from youknowriad Sep 18, 2018

@youknowriad

LGTM 👍

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad Sep 18, 2018

Contributor

Let's see what travis says.

Contributor

youknowriad commented Sep 18, 2018

Let's see what travis says.

@afercia

This comment has been minimized.

Show comment
Hide comment
@afercia

afercia Sep 18, 2018

Contributor

Tested also with IE 11 with the fix from #10000, all green on Travis. Merging.

Contributor

afercia commented Sep 18, 2018

Tested also with IE 11 with the fix from #10000, all green on Travis. Merging.

@afercia afercia merged commit 779c3c5 into master Sep 18, 2018

2 checks passed

codecov/project 48.8% remains the same compared to 7c7e764
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@afercia afercia deleted the update/reusable-blocks-export-as-json-link branch Sep 18, 2018

@mtias mtias added this to the 4.0 milestone Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment