New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix manifest entry; (chore) update data docs #10014

merged 1 commit into from Sep 18, 2018


None yet
2 participants

mcsf commented Sep 18, 2018


Follow-up on #9837 (comment). I'd mistakenly updated docs/manifest.json, which is auto-generated from other sources, including docs/root-manifest.json.


Run npm run docs:build, make sure that docs/manifest.json is kept intact (that the entry for isn't removed).


aduth approved these changes Sep 18, 2018

Thanks 👍

@mcsf mcsf added this to the 4.0 milestone Sep 18, 2018

@mcsf mcsf merged commit c9d3669 into master Sep 18, 2018

2 checks passed

codecov/project 48.78% remains the same compared to bd5910b
continuous-integration/travis-ci/pr The Travis CI build passed

@mcsf mcsf deleted the fix/docs-grammar-root-manifest branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment