Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix focused header layout for IE11 #10017
This PR addresses a layout bug in IE11 which occurs when using
How has this been tested?
Manually tested by navigating to the header region in IE11, Edge, Chrome, Firefox, and Safari and observing no undesired layout changes.
Types of changes
The layout issue is caused by a combination of:
The focused region outline is absolutely positioned, but IE11 adds space between it and the last header element, shifting the UI to the left. This PR adds a workaround that moves the pseudo element in the flex order where the undesired extra space does not visibly affect the layout.
Very cool work, thanks for working on this. Confirmed, it fixes it:
However right now this is implemented for all browsers, not just IE.
Should we use our IE hack to unset this rule for modern browsers? It works sort of like this: