New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste: Omit <style> tags #10019

Merged
merged 3 commits into from Sep 20, 2018

Conversation

Projects
None yet
2 participants
@mcsf
Contributor

mcsf commented Sep 18, 2018

Description

Fixes #9719

How has this been tested?

  • Verify all block-conversion integration tests pass, including newly added ms-word-styled.
  • Try reproducing parent issue.
  • Stress-test pasting or classic-to-blocks conversion with whatever input.

Questions

  • Properly investigate the regression (this was seemingly working in 2.0), rather than "just fix" as I did.
  • Figure out if it's worth keeping a dedicated HTML.replace call to strip meta tags instead of relying on proper node processing.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

mcsf and others added some commits Sep 18, 2018

Raw handling: remove <style> tags
- Input file for integration test `ms-word-styled` is a truncated
version of file provided by issue reporter. See
#9719 (comment)

@mcsf mcsf merged commit 640eb98 into master Sep 20, 2018

2 checks passed

codecov/project 48.67% (+0.01%) compared to 6e2caf1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/raw-handling-word-doc-style branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment