New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: Replace length check with RichText.isEmpty #10029

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
3 participants
@iseulde
Member

iseulde commented Sep 19, 2018

Description

This was forgotten in #9249. Split out from #7890.

How has this been tested?

Ensure the image block still works.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde added this to the 4.0 milestone Sep 19, 2018

@iseulde iseulde requested a review from WordPress/gutenberg-core Sep 19, 2018

@jorgefilipecosta

LGTM 👍

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Sep 19, 2018

Member

Thanks!

Member

iseulde commented Sep 19, 2018

Thanks!

@iseulde iseulde merged commit 32a9c1a into master Sep 19, 2018

2 checks passed

codecov/project 48.69% remains the same compared to eb7cd69
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/image-rich-text-is-empty branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment