New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to define isRichTextValueEmpty for mobile too #10037

Merged
merged 2 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@hypest
Contributor

hypest commented Sep 19, 2018

Description

This PR moves the definition of the isRichTextValueEmpty function into a common module and uses it for the mobile rich-text/index.native.js implementation too. This fixes the breakage of npm test in current master.

How has this been tested?

npm install, npm test now succeeds on the mobile tests.

Types of changes

  • Code refactoring to move isRichTextValueEmpty() in a common module (./utils.js)
  • rich-text/index.native.js using the new ./utils.js

To Test:

  1. npm install
  2. npm test
  3. tests should pass

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@hypest hypest requested a review from iseulde Sep 19, 2018

@hypest hypest requested a review from WordPress/gutenberg-core Sep 19, 2018

@iseulde

Sounds good to me!

@hypest hypest merged commit 31497c2 into master Sep 19, 2018

2 checks passed

codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.3% compared to 32a9c1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hypest hypest deleted the rnmobile/define-isrichtextvalueempty-for-mobile-too branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment