/gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder: Consistent input field width #10087

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Reviewers

@jasmussen jasmussen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  4.0
2 participants
@Soean @jasmussen
@Soean
Member

Soean commented Sep 21, 2018

Description

To make the Placeholder form width consistent with the MediaPlaceholder form and to show the full input placeholder with the german translation, this PR sets the max-width to 400px.

Fixes #8107

Screenshots

Before
bildschirmfoto 2018-09-21 um 12 35 55

After
bildschirmfoto 2018-09-21 um 12 35 32
@Soean
Set default width to 400px
Loading status checks…
173f944

@Soean Soean added the Needs Design Feedback label Sep 21, 2018

@jorgefilipecosta jorgefilipecosta requested a review from jasmussen Sep 25, 2018

@jasmussen

jasmussen approved these changes Sep 25, 2018
View changes

Nice work! Put it in a milestone and ship it!

@Soean Soean added this to the 4.0 milestone Sep 25, 2018

@Soean Soean merged commit 598fffa into master Sep 25, 2018
2 checks passed

2 checks passed

codecov/project 48.79% remains the same compared to a8bc550
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Soean Soean removed the Needs Design Feedback label Sep 25, 2018

@Soean Soean deleted the update/url-input-width branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment