New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shortcode package dependencies #10140

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
4 participants
@youknowriad
Contributor

youknowriad commented Sep 24, 2018

Installing the shortcode package using npm leads to an unresolved dependency (memize).

@youknowriad youknowriad self-assigned this Sep 24, 2018

@youknowriad youknowriad requested review from gziolo, aduth and WordPress/gutenberg-core Sep 24, 2018

@tofumatt

Makes sense to me!

@gziolo gziolo added this to the 4.0 milestone Sep 25, 2018

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo Sep 25, 2018

Member

Yes, nice one, let's get it in 👍

Member

gziolo commented Sep 25, 2018

Yes, nice one, let's get it in 👍

@gziolo gziolo merged commit 3454780 into master Sep 25, 2018

2 checks passed

codecov/project 48.81% remains the same compared to 51f0174
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the fix/shortcode-package branch Sep 25, 2018

@aduth

This comment has been minimized.

Show comment
Hide comment
@aduth

aduth Sep 26, 2018

Member

This should have updated the lock file. There are local changes on master after running npm install.

Member

aduth commented Sep 26, 2018

This should have updated the lock file. There are local changes on master after running npm install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment