New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add E2E tests for list creation (see #7890) #10143

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@tofumatt
Member

tofumatt commented Sep 24, 2018

Adds tests for list creation after regressions were found in #7890.

Would be good to get these in and then use them for #7890. 馃槃

chore: Add E2E tests for list creation (see #7890)
Adds tests for list creation after regressions were found in #7890.

@tofumatt tofumatt requested review from mcsf and WordPress/gutenberg-core Sep 24, 2018

@tofumatt tofumatt added this to the 4.0 milestone Sep 24, 2018

@gziolo

gziolo approved these changes Sep 25, 2018

This is a really great addition. In the long run, it would be awesome to have one test suite per block type (probably all grouped in one folder).

@gziolo gziolo merged commit 2d2e4ef into master Sep 25, 2018

2 checks passed

codecov/project 48.81% remains the same compared to 51f0174
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the chore/add-list-item-tests-for-7890 branch Sep 25, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Sep 25, 2018

Member

Indeed, I was thinking that when doing some earlier tests. At some point I鈥檒l go through and tidy them up according to block type, but I want to hold off on the noisy diff for now 馃槉

Member

tofumatt commented Sep 25, 2018

Indeed, I was thinking that when doing some earlier tests. At some point I鈥檒l go through and tidy them up according to block type, but I want to hold off on the noisy diff for now 馃槉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment