New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise middleware: Avoid dispatching undefined results #10155

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@youknowriad
Contributor

youknowriad commented Sep 25, 2018

This should fix unit tests in node8 locally.

@youknowriad youknowriad self-assigned this Sep 25, 2018

@youknowriad youknowriad requested a review from gziolo Sep 25, 2018

@gziolo

gziolo approved these changes Sep 25, 2018

This solves the issue I raised on WordPress.org Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1537861160000100.

 ● createRegistry › registerResolvers › should resolve promise non-action to dispatch

    Actions must be plain objects. Use custom middleware for async actions.

      at dispatch (node_modules/redux/lib/createStore.js:165:13)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 20 passed, 21 total
Snapshots:   0 total
Time:        1.206s, estimated 2s

@youknowriad youknowriad merged commit bcb5f83 into master Sep 25, 2018

2 checks passed

codecov/project 48.82% (+<.01%) compared to 973d8c9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/unit-test-node8 branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment