New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with Button placeholder text #10160

Merged
merged 1 commit into from Sep 25, 2018

Conversation

Projects
None yet
2 participants
@jasmussen
Contributor

jasmussen commented Sep 25, 2018

A recent change to placeholder text contrast caused this to regress. This PR fixes that.

Before:

screen shot 2018-09-25 at 14 05 14

After:

screen shot 2018-09-25 at 14 12 05

Fix regression with Button placeholder text
A recent change to placeholder text contrast caused this to regress. This PR fixes that.

@jasmussen jasmussen added this to the 4.0 milestone Sep 25, 2018

@jasmussen jasmussen self-assigned this Sep 25, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Sep 25, 2018

@tofumatt

Makes sense to me.

@@ -18,10 +18,15 @@
cursor: text;
line-height: 1;
}
&:not(.has-text-color) .editor-rich-text__tinymce[data-is-placeholder-visible="true"] + .editor-rich-text__tinymce {

This comment has been minimized.

@tofumatt

tofumatt Sep 25, 2018

Member

That’s quite the selector! 😅

Any chance there’s anything less intense we can use? No worries if not.

@tofumatt

tofumatt Sep 25, 2018

Member

That’s quite the selector! 😅

Any chance there’s anything less intense we can use? No worries if not.

This comment has been minimized.

@jasmussen

jasmussen Sep 25, 2018

Contributor

Not really, sadly — the way we create placeholder text in fields like these is rather exotic, so it has to use the plus selector. We also want to make sure that the actual text color is only applied when a user specified one isn't, in that case we want to rely on opacity for the user customized placeholder text color :)

@jasmussen

jasmussen Sep 25, 2018

Contributor

Not really, sadly — the way we create placeholder text in fields like these is rather exotic, so it has to use the plus selector. We also want to make sure that the actual text color is only applied when a user specified one isn't, in that case we want to rely on opacity for the user customized placeholder text color :)

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Sep 25, 2018

Contributor

Thanks for the review!

Contributor

jasmussen commented Sep 25, 2018

Thanks for the review!

@jasmussen jasmussen merged commit d4001b4 into master Sep 25, 2018

2 checks passed

codecov/project 48.83% remains the same compared to bcb5f83
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasmussen jasmussen deleted the fix/button-placeholder branch Sep 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment