New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ESNext example code #10184

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@ericnmurphy
Contributor

ericnmurphy commented Sep 26, 2018

Description

Fixed errors that prevented it from rendering and rearranged blocks to mirror ES5 example code.

How has this been tested?

Tests ran in a local PHP environment. Used create-guten-block to bootstrap the block plugin, and tested inside the plugin to make sure the code worked in the local Wordpress.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Fixed ESNext example code
Fixed errors that prevented it from rendering and rearranged blocks to mirror ES5 example code.
@jorgefilipecosta

Hi @ericnmurphy, thank you a lot for your contribution, your changes look good to me 👍
I checked that the existing code is not following the conventions e.g: spaces & tabs mixed etc... Given that we are fixing this code block in this PR, would it be possible to add this additional updates to the PR? Let me know if you need any help!

Show outdated Hide outdated docs/extensibility/extending-blocks.md Outdated
Show outdated Hide outdated docs/extensibility/extending-blocks.md Outdated
@ericnmurphy

This comment has been minimized.

Show comment
Hide comment
@ericnmurphy

ericnmurphy Sep 27, 2018

Contributor

Hey @jorgefilipecosta, went through and fixed all the formatting issues. Thanks for letting me know!

Contributor

ericnmurphy commented Sep 27, 2018

Hey @jorgefilipecosta, went through and fixed all the formatting issues. Thanks for letting me know!

@ericnmurphy

This comment has been minimized.

Show comment
Hide comment
@ericnmurphy

ericnmurphy Oct 8, 2018

Contributor

@jorgefilipecosta, just wanted to check in with this—is this ready to merge?

Contributor

ericnmurphy commented Oct 8, 2018

@jorgefilipecosta, just wanted to check in with this—is this ready to merge?

@jorgefilipecosta

Thank you for iterating on this changes! The changes look good to me 👍

@jorgefilipecosta jorgefilipecosta merged commit f02c054 into WordPress:master Oct 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jorgefilipecosta

This comment has been minimized.

Show comment
Hide comment
@jorgefilipecosta

jorgefilipecosta Oct 8, 2018

Member

Sorry, @ericnmurphy I missed your ping. The changes look good to me and the PR was merged thank you for your contribution 👍

Member

jorgefilipecosta commented Oct 8, 2018

Sorry, @ericnmurphy I missed your ping. The changes look good to me and the PR was merged thank you for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment