New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit post: Convert tools more menu group into internal plugin #10194

Merged
merged 3 commits into from Sep 28, 2018

Conversation

Projects
None yet
2 participants
@gziolo
Member

gziolo commented Sep 26, 2018

Description

This PR removes internal filters included in More Menu groups. They were never publicly promoted so I don't expect them to cause any issues at all. If you still think that we should include a deprecation message, I'm fine to add it. I don't expect any plugin to use it because it would require very careful study of the code. It was used only as an exploration for the Tools group and the copy button.

This PR does the following:

  • removes all the filters which were meant to make More Menu extensible - this caused lots of confusion recently and raised some question
  • adds new internal More Menu group slot for Tools
  • adds internal registerPlugin call to dogfood Edit Post page with Plugins API

This change will allow use to continue refactoring towards having Edit Post more plugins oriented architecture and a good set of examples to follow by plugins.

How has this been tested?

There should be no visual change. All More Menu items should look and work as before.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo self-assigned this Sep 26, 2018

@gziolo gziolo requested review from mcsf, youknowriad and aduth Sep 26, 2018

@@ -2421,7 +2421,8 @@
"version": "file:packages/shortcode",
"requires": {
"@babel/runtime": "^7.0.0",
"lodash": "^4.17.10"
"lodash": "^4.17.10",
"memize": "^1.0.5"

This comment has been minimized.

@gziolo

gziolo Sep 26, 2018

Member

This pops up in every PR I open, we should fix it.

@gziolo

gziolo Sep 26, 2018

Member

This pops up in every PR I open, we should fix it.

@mcsf

mcsf approved these changes Sep 27, 2018

Nice one!

Show outdated Hide outdated packages/components/src/menu-group/index.js Outdated
import TipsToggleMenuItem from './tips-toggle-menu-item';
import ToolsMoreMenuGroup from '../components/header/tools-more-menu-group';
registerPlugin( 'edit-post', {

This comment has been minimized.

@mcsf

mcsf Sep 27, 2018

Contributor

😎

@mcsf

mcsf Sep 27, 2018

Contributor

😎

@gziolo gziolo added this to the 4.0 milestone Sep 28, 2018

@gziolo gziolo merged commit a577d0e into master Sep 28, 2018

2 checks passed

codecov/project 48.52% (-0.11%) compared to 5c2085a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the update/more-menu-plugin branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment