New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery margin while typing #10221

Merged
merged 1 commit into from Sep 28, 2018

Conversation

Projects
None yet
3 participants
@kjellr
Contributor

kjellr commented Sep 27, 2018

#10027 introduced a small bug where the last item in a gallery sometimes jumps around when a user is in the process of adding a caption.

This is due to a :nth-last-child(2) style rule that is applied to a gallery when it has an is-selected class, but not an is-typing class.

This PR modifies that rule to include the is-typing class and remove the jump.

Before:
broken

After
fixed

Fix gallery margin while typing.
#10027 introduced a small bug where the last item in a gallery jumps around when a user is in the process of adding a caption.

This is due to a `:nth-last-child(2)` style rule that is applied to a gallery when it has an `is-selected` class, but not an `is-typing` class.

This PR modifies that rule to include the `is-typing` class and remove the jump.

@kjellr kjellr requested review from talldan and jasmussen Sep 27, 2018

@jasmussen

Awesome. Confirmed both the issue, and that this fixes it. Ship it!

@jasmussen jasmussen added this to the 4.0 milestone Sep 28, 2018

@talldan

This comment has been minimized.

Show comment
Hide comment
@talldan

talldan Sep 28, 2018

Contributor

Great catch!

Contributor

talldan commented Sep 28, 2018

Great catch!

@kjellr kjellr merged commit 3eacbf9 into master Sep 28, 2018

2 checks passed

codecov/project 48.63% remains the same compared to 8af1f62
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kjellr kjellr deleted the fix/gallery-padding-while-typing branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment