Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix wide regression #10228
This fixes a regression where wide images would cause horizontal scrollbars. Try the demo content in master, note that there are horizontal scrollbars. Then try this branch, note that they are gone.
The issue: the margins on the figure weren't being reset left and right on wide image.
I will investigate why this regression happened, I suspect it was related to the side-padding normalization.
Things looked great in my tests
Thank you Jorge for the review, but I discovered this issue was bigger than just for wide and fullwide:
it's even for normal images that are inserted.
We used to simply set
Requesting another review because it's a biggish change. @kjellr can you look also?