New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix faulty Jed state after setLocaleData #10233

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@atimmer
Member

atimmer commented Sep 28, 2018

Description

When calling setLocaleData with a custom textdomain in a non-Gutenberg environment the default textdomain ends up in a state that is not ok with Jed resulting in the error: "Error: No locale meta information provided." In Gutenberg this is not a problem because setLocaleData is always called first with the default textdomain.

How has this been tested?

Using hotfix/8.3.1 of Yoast SEO we found this bug. After the removal of getI18n from our code we uncovered this.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
Fix faulty Jed state after setLocaleData
When calling `setLocaleData` with a custom textdomain in a non-Gutenberg environment the default textdomain ends up in a state that is not ok with Jed resulting in the error: "Error: No locale meta information provided." In Gutenberg this is not a problem because `setLocaleData` is always called first with the default textdomain.

@atimmer atimmer requested review from youknowriad and gziolo Sep 28, 2018

@atimmer

This comment has been minimized.

Show comment
Hide comment
@atimmer

atimmer Sep 28, 2018

Member

Note: I can add a changelog entry, but I have no idea how to describe this concisely.

Member

atimmer commented Sep 28, 2018

Note: I can add a changelog entry, but I have no idea how to describe this concisely.

@youknowriad youknowriad requested a review from aduth Sep 29, 2018

@gziolo gziolo added this to the 4.0 milestone Oct 4, 2018

@aduth

aduth approved these changes Oct 4, 2018

Added CHANGELOG note.

@gziolo gziolo merged commit dcd5cd1 into master Oct 4, 2018

2 checks passed

codecov/project 49.29% (+0.72%) compared to dff799b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@youknowriad youknowriad deleted the fix/jed-default-textdomain-faulty-state branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment