New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Image: Add configurable overlay color #10291

Merged
merged 3 commits into from Oct 4, 2018

Conversation

Projects
None yet
5 participants
@mcsf
Contributor

mcsf commented Oct 2, 2018

Description

cover-image-overlay-color

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@mcsf mcsf added the Blocks label Oct 2, 2018

@mcsf mcsf requested a review from mtias Oct 2, 2018

@aduth aduth self-requested a review Oct 3, 2018

const style = backgroundImageStyles( url );
if ( ! overlayColorClass ) {
style.backgroundColor = customOverlayColor;

This comment has been minimized.

@aduth

aduth Oct 3, 2018

Member

backgroundImageStyles can return undefined which would throw an error here. Can that happen?

@aduth

aduth Oct 3, 2018

Member

backgroundImageStyles can return undefined which would throw an error here. Can that happen?

This comment has been minimized.

@mcsf

mcsf Oct 3, 2018

Contributor

Good spot. Addressed.

@mcsf

mcsf Oct 3, 2018

Contributor

Good spot. Addressed.

Show outdated Hide outdated packages/block-library/src/cover-image/index.js
@tofumatt

This is cool! I just have a few comments, not really a full review.

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Oct 3, 2018

Contributor

af2154f should take care of all the feedback.

Contributor

mcsf commented Oct 3, 2018

af2154f should take care of all the feedback.

@mcsf

This comment has been minimized.

Show comment
Hide comment
@mcsf

mcsf Oct 3, 2018

Contributor

Note that E2E test failure comes from master.

Contributor

mcsf commented Oct 3, 2018

Note that E2E test failure comes from master.

@jorgefilipecosta

I left a review with some possible enhancements but things tested well for me. I did not found any blocker.

checked={ hasParallax }
onChange={ toggleParallax }
/>
<PanelColorSettings

This comment has been minimized.

@jorgefilipecosta

jorgefilipecosta Oct 4, 2018

Member

PanelColorSettings includes a small rectangle with the color preview. As a possible improvement, we may apply the opacity CSS to that rectangle so the color preview is more reliable.

@jorgefilipecosta

jorgefilipecosta Oct 4, 2018

Member

PanelColorSettings includes a small rectangle with the color preview. As a possible improvement, we may apply the opacity CSS to that rectangle so the color preview is more reliable.

@mtias mtias self-requested a review Oct 4, 2018

@mtias

mtias approved these changes Oct 4, 2018

@mcsf mcsf merged commit a01b009 into master Oct 4, 2018

2 checks passed

codecov/project 49.59% (+0.16%) compared to d6af165
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mcsf mcsf deleted the update/cover-image-overlay-color branch Oct 4, 2018

@mtias mtias added this to the 4.0 milestone Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment