Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix guided tour popup margins #10295
Removed negative left and right margins from guided tour popup when scrolling on mobile devices.
How has this been tested?
Fix had been tested using iPhone 7 Plus with iOS 11.4.1 in both English (LTR) and Hebrew (RTL).
Types of changes
Removed two negative margins (LTR & RTL) within
referenced this pull request
Oct 2, 2018
Thanks for the patch!
I think this makes sense and looks good, but I'm a bit confused about the screenshots you've submitted. It looks like there are "before" and "after" screenshots, but I can't tell which ones are which so it's hard to tell what the change is here.
Could you edit your PR comment to clarify the before/after screenshots and have a look at the comments I made? After that this should be good to merge