Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Hover fix #10333
How has this been tested?
Tested on iOS 12 Safari - and Firefox Focus
Types of changes
tofumatt left a comment
Shoot; thought I approved this but I must've got distracted by another tab or a shiny object
Thanks for the PR and thanks for the screenshots; they really helped!
I tweaked your comment to point to the PR and this looks good. I'll merge it once Travis is green
Nov 14, 2018
1 check failed
So I haven't tested this yet, but it sounds sad when reading this.
I actually use my phone (Samsung Galaxy S9+) with Samsung DeX for all of my development work. I hope hovering will still work on my phone. I don't want this disabled at all. It will be awful if :hover is disabled for mobile.
@shaunroselt could you share a specific example of this? With most phones, it's required to actually click something in order to open up a section, not hover over (you can't hover with a finger).
That said, the only change it that it doesn't show up as a different colour on mobile.
@jobthomas You can however hover with a mouse. I have an external monitor, keyboard and mouse plugged into my phone and then I use it like this. So I actually use the :hover on mobile with my mouse.
I plan on slowly upgrading all of my old websites to WordPress 5 and Gutenberg when it comes out as well as do all my future websites in WordPress 5 and Gutenberg. I definitely want hover to keep working on my phone. I have a mouse connected to my phone 70% of the time. So I don't really use a finger at all, but I do use a mouse. I have a Logitech G502 Mouse at home and a Cooler Master MS120 Mouse at work. I use them both with my phone.
Just as reference, the
All this does is not change the colours of the hover option if the screen is less wide than 782px.
@jobthomas Okay that sounds better. Thanks. I have a 1920x1080 monitor at home and work for my phone. My actual phone resolution is just a bit bigger than 1440p.