New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused isButton prop #10357

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
2 participants
@Rahmon
Contributor

Rahmon commented Oct 5, 2018

Description

FontSizePicker component was passing isButton prop to Button component but this component doesn't use isButton in any place.

The warning below show up in console:
Warning: React does not recognize the isButton prop on a DOM element.

How has this been tested?

This has been tested with "npm test" and manually on Chrome

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@Soean

Soean approved these changes Oct 8, 2018

Already fixed in #9786 reintroduced in #9802

@Soean Soean merged commit d316ac5 into WordPress:master Oct 8, 2018

2 checks passed

codecov/project 49.32% remains the same compared to 3770364
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Soean Soean added this to the 4.0 milestone Oct 8, 2018

@Rahmon Rahmon deleted the Rahmon:fix/unusedProp branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment