New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mentions after rich text value merge #10369

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@iseulde
Member

iseulde commented Oct 5, 2018

Description

Mentions are broken because I forgot to update the create call after I changed that function in the PR and we didn't catch it before merge. I added an e2e test to ensure it doesn't happen again.

How has this been tested?

Trigger autocomplete with @... and press enter to insert.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@iseulde iseulde added this to the 4.0 milestone Oct 5, 2018

@iseulde iseulde requested a review from WordPress/gutenberg-core Oct 5, 2018

@youknowriad

Thanks for the test, looks good. Let's wait for travis.

@iseulde

This comment has been minimized.

Show comment
Hide comment
@iseulde

iseulde Oct 5, 2018

Member

Thanks @youknowriad for the quick review!

Member

iseulde commented Oct 5, 2018

Thanks @youknowriad for the quick review!

@iseulde iseulde merged commit 8510c7f into master Oct 5, 2018

2 checks passed

codecov/project 49.31% remains the same compared to baff0e6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@iseulde iseulde deleted the fix/mentions branch Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment