Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Fix] Establish consistency between front-end and back-end classes for Youtube (Embed) block #10411
This PR closes #10121 which reports the usage of
How has this been tested?
This PR has been tested by going through the following steps:
This was tested in WP 4.9.8, Gutenberg 3.9.0, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Types of changes
This PR just replaces the
referenced this pull request
Oct 9, 2018
I'm torn. Adding a deprecation is easy in technical terms, but they come with added maintenance cost, and I'd also like us to keep new deprecations to an essential minimum at this stage of development. Perhaps @jasmussen 's gut can estimate use of
Nice catches. To decide whether we can skip the deprecation handler, we can ask some questions:
My personal opinion is that we should not worry about the deprecation handler. Since my gut was asked, my gut responds that this isn't widely optimized for, and in cases where it is, it's both an easy fix and the visual regression potentially caused by its removal should be minimal.
On the flipside, the price of technical debt piling up based on deprecation handlers isn't trivial.
I'll try to answer the questions that @jasmussen pointed out according to my observation and investigation:
In my honest opinion, I think a deprecation handler for this minor change unnecessary.
Oct 15, 2018
added a commit
this pull request
Oct 15, 2018
Chrome newest version I think on my Macbook Pro.
Here I just pasted a Youtube link directly into a paragraph area and the video showed up...:)