New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pullquote margin regressions. #10425

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@jasmussen
Contributor

jasmussen commented Oct 9, 2018

Since the addition of the figure element to the pullquote, the margins were not reset it seems. This PR resets the intrinsic left and right margin on the figure to address that.

Before:

screenshot 2018-10-09 at 10 11 50

After:

screenshot 2018-10-09 at 10 13 08

Fix pullquote margin regressions.
Since the addition of the figure element to the pullquote, the margins were not reset it seems. This PR resets the intrinsic left and right margin on the figure to address that.

@jasmussen jasmussen added this to the 4.1 milestone Oct 9, 2018

@jasmussen jasmussen self-assigned this Oct 9, 2018

@jasmussen jasmussen requested a review from WordPress/gutenberg-core Oct 9, 2018

@tofumatt

Makes sense to me!

@mtias mtias merged commit b76e140 into master Oct 9, 2018

2 checks passed

codecov/project 49.43% remains the same compared to cc5bf5c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mtias mtias deleted the fix/pullquote-margins branch Oct 9, 2018

@gziolo gziolo modified the milestones: 4.1, 4.0 Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment