Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clean up variables, comments, reduce complexity #10430
This PR does a few things:
Aside from a good code review and testing, this needs a visual regression sanity check. The $grid-size variable is 8px, whereas $item-spacing was 10px. In my own testing, this caused no issues, but it would still be good to check a bit more in-depth. If some margins are now too small, we can consider a 12px variant, or jump directly to 16px.
I rebased, and fixed the visual regression:
Although that aspect is no longer fully base-8 gridbased, this is to be expected. The regression here is that the X is a dashicon (base10 grid), and the chevrons are material icons (base8 grid). So I had to make an exception there to make them align.