New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make "Manage Reusable Blocks" a link #10454

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
4 participants
@tofumatt
Member

tofumatt commented Oct 9, 2018

Fix #10009.

Description

Convert the "Manage all Reusable Blocks" button to a link. Previously, it was an icon-only button, which isn't good for accessibility or UX, and caused confusion regarding the result of interacting with the button (see: #10435).

This makes it clear the item is a link which will navigate to another part of the site.

How has this been tested?

Tested locally in Firefox and Chrome, link works as expected. No longer looks like a button that doesn't act like one.

Screenshots

Before

screenshot 2018-10-09 21 23 01

screenshot 2018-10-09 21 22 52

After

screenshot 2018-10-10 00 21 59

@tofumatt tofumatt added this to the 4.1 milestone Oct 9, 2018

@tofumatt tofumatt requested review from karmatosed, jasmussen, afercia and WordPress/gutenberg-core Oct 9, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Oct 9, 2018

Member

I centered the text because I thought it was nice. Feel free to adjust that 😉

Member

tofumatt commented Oct 9, 2018

I centered the text because I thought it was nice. Feel free to adjust that 😉

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Oct 9, 2018

Member

As requested by @karmatosed in the issue (#10009 (comment)), I've moved the text; it's now right-aligned.

Member

tofumatt commented Oct 9, 2018

As requested by @karmatosed in the issue (#10009 (comment)), I've moved the text; it's now right-aligned.

@noisysocks

Tests well and looks good from a code perspective 👍

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Oct 10, 2018

Contributor

I think the location of the link in the inserter is something that, in the future, should probably be reconsidered. The block library feels like it should contain only blocks, like a drawer that is intentionally created to hold a specific type of items, and when it contains a link like this it feels weird like an odd thing that "sticks out", especially given we also have a link in the menu (though to be clear this is an issue with both the link and the icon button). However it's also probably necessary there, because users might discover that link from the reusable blocks section.

In other words, this is fine, ship it. But it'd be nice if the reusable blocks management UI could see improvement separately in the future. But such it is with software, work is never over, and perfection is always around the next corner. Good thing 5.1 is already slated for early 2019.

Nice work.

Contributor

jasmussen commented Oct 10, 2018

I think the location of the link in the inserter is something that, in the future, should probably be reconsidered. The block library feels like it should contain only blocks, like a drawer that is intentionally created to hold a specific type of items, and when it contains a link like this it feels weird like an odd thing that "sticks out", especially given we also have a link in the menu (though to be clear this is an issue with both the link and the icon button). However it's also probably necessary there, because users might discover that link from the reusable blocks section.

In other words, this is fine, ship it. But it'd be nice if the reusable blocks management UI could see improvement separately in the future. But such it is with software, work is never over, and perfection is always around the next corner. Good thing 5.1 is already slated for early 2019.

Nice work.

@gziolo gziolo merged commit f232447 into master Oct 10, 2018

2 checks passed

codecov/project 49.48% (-0.02%) compared to 471e581
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gziolo gziolo deleted the fix/10009-manage-all-should-be-link branch Oct 10, 2018

@gziolo gziolo modified the milestones: 4.1, 4.0 Oct 10, 2018

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Oct 10, 2018

Member

Agreed 100%. This is still a pretty janky UX, but at least the jank is well-communicated with it being a link now. 😆

Member

tofumatt commented Oct 10, 2018

Agreed 100%. This is still a pretty janky UX, but at least the jank is well-communicated with it being a link now. 😆

@noisysocks

This comment has been minimized.

Show comment
Hide comment
@noisysocks

noisysocks Oct 11, 2018

Member

The block library feels like it should contain only blocks, like a drawer that is intentionally created to hold a specific type of items, and when it contains a link like this it feels weird like an odd thing that "sticks out", especially given we also have a link in the menu (though to be clear this is an issue with both the link and the icon button).

Do we need both this link and the Mange All Reusable Blocks menu item?

Member

noisysocks commented Oct 11, 2018

The block library feels like it should contain only blocks, like a drawer that is intentionally created to hold a specific type of items, and when it contains a link like this it feels weird like an odd thing that "sticks out", especially given we also have a link in the menu (though to be clear this is an issue with both the link and the icon button).

Do we need both this link and the Mange All Reusable Blocks menu item?

@jasmussen

This comment has been minimized.

Show comment
Hide comment
@jasmussen

jasmussen Oct 11, 2018

Contributor

Do we need both this link and the Mange All Reusable Blocks menu item?

That's the million dollar question.

My gut says yes because reusable blocks are a new concept, and we can speculate a user might intuitively want to look for options in the block library. Also, redundant interfaces is not the end of the world.

But it would be nice to remove it if we had some way to know that the More menu link was sufficient.

Contributor

jasmussen commented Oct 11, 2018

Do we need both this link and the Mange All Reusable Blocks menu item?

That's the million dollar question.

My gut says yes because reusable blocks are a new concept, and we can speculate a user might intuitively want to look for options in the block library. Also, redundant interfaces is not the end of the world.

But it would be nice to remove it if we had some way to know that the More menu link was sufficient.

@tofumatt

This comment has been minimized.

Show comment
Hide comment
@tofumatt

tofumatt Oct 11, 2018

Member
Member

tofumatt commented Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment