Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: make "Manage Reusable Blocks" a link #10454
Convert the "Manage all Reusable Blocks" button to a link. Previously, it was an icon-only button, which isn't good for accessibility or UX, and caused confusion regarding the result of interacting with the button (see: #10435).
This makes it clear the item is a link which will navigate to another part of the site.
How has this been tested?
Tested locally in Firefox and Chrome, link works as expected. No longer looks like a button that doesn't act like one.
requested review from
Oct 9, 2018
I think the location of the link in the inserter is something that, in the future, should probably be reconsidered. The block library feels like it should contain only blocks, like a drawer that is intentionally created to hold a specific type of items, and when it contains a link like this it feels weird like an odd thing that "sticks out", especially given we also have a link in the menu (though to be clear this is an issue with both the link and the icon button). However it's also probably necessary there, because users might discover that link from the reusable blocks section.
In other words, this is fine, ship it. But it'd be nice if the reusable blocks management UI could see improvement separately in the future. But such it is with software, work is never over, and perfection is always around the next corner. Good thing 5.1 is already slated for early 2019.
Oct 10, 2018
Do we need both this link and the Mange All Reusable Blocks menu item?
That's the million dollar question.
My gut says yes because reusable blocks are a new concept, and we can speculate a user might intuitively want to look for options in the block library. Also, redundant interfaces is not the end of the world.
But it would be nice to remove it if we had some way to know that the More menu link was sufficient.
WordPress.com Gutenberg usage stats could probably tell us that, but having the manage link right next to the items _seems_ nice; it’s just a shame they link elsewhere, but that’s another issue really—building a way to mange them within the editor is a much bigger task. - Matt (Sent from mobile)…
On 11 Oct 2018, at 07:41, Joen Asmussen ***@***.***> wrote: Do we need both this link and the Mange All Reusable Blocks menu item? That's the million dollar question. My gut says yes because reusable blocks are a new concept, and we can speculate a user might intuitively want to look for options in the block library. Also, redundant interfaces is not the end of the world. But it would be nice to remove it if we had some way to know that the More menu link was sufficient. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.